[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 20 Apr 2022 15:22:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ajc7tNbbGPWIctUbbCGk2QBq3ugT/V+TsK8nwL4vgrc=; b=R0yOzXoFNJbbCfj1ekVvIj8b/4pZskk+Xpbs1R1OV1G3q+PQflOpAtQhzVMsZHU2aj7DGPBbRDChC82b0b7da+DPffXO0a9UPb7H8SJ4/EszEB8wV/Azfzly+fZzcqa5GnLFrdkRF7XZm/4shv6yLClKNPXBUQFENt7CX2EchjzGZhN5H1aFLgflbLUUdtqMYrRRJyjLe+qzaYQlStOMgqHPJQ6KLZOziTQ/FnqHmonnjY9PFDKg/wJILCfDu/3Wecm+OqPlFJoG0jXu+zYa6AFcn8e/eIpDfefjLJjFOuOGUwaMHiVGtOkTzE1Fy8NgR1AT6HALPG87NYCQHO+ymg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXeE8/WtlgPbw+XeWo7px7IbI8n1w3T3Q63A5sSiK+fFq1tMMOkW7RDrFNePkGsmFMSQzNQ2C/PUn+0Pa89TLCisK7Hqw/Kgm+Fpwu30itiRrn4aECVnsVU2i1wDP1/Kzk+S8QNpff5DjR6lzsaAZUfcrJzrVOpq/z0qVH/IdEIwa0EU9hBjHtGaeVCd21jFuVQouyWKB29FizWkkAe9d5Yo2QV3qO4yDFjMNZU0mBIMBVXHbp818qmZMaohzHr0cuYpQ4iMVcHqUrnvc4ivEwp+AFwPLYsnI62q2MCTDGFacr1/7Kv/NcSU8sGhh4t4pS78BJT0pC9vZ4g5cYtPig==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 15:22:50 +0000
- Ironport-data: A9a23:7bcSHq3hIXaFvO0AavbD5e9wkn2cJEfYwER7XKvMYLTBsI5bpzVSy jNOWT2CPfnYZWqhLt8ibYyypB4O6MXQn4VlGQFtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy2YDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /11lsyNVxoTIZHDo/UiWTVTF3FZfup/reqvzXiX6aR/zmXgWl60mbBCKRpzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfmajTNb9G5YasRmNPDSf ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUG+Q7N/fJtugA/yiQh9ZvDaOTyJOa0Yu5phEzCv m7r9UnAV0Ry2Nu3jGDtHmiXru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJvH5XhulsDuHswQaVt54DeI38keOx7DS7gLfAXILJhZLb8Ynr4kxXiAw0 UGSnMLBAiZmu7mYD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXryos1LFae0ipj5HGr2y jXS8ywm3e1P3YgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2toji0bnlePSxfdgw
- Ironport-hdrordr: A9a23:ywEnaa+2CbB9/t0GwkFuk+GBdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmdsPeEQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVMkyGaYzhccwwkWCnGeb0Tf8nKz461YA
- Thread-topic: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()
On 20/04/2022 16:09, Juergen Gross wrote:
> diff --git a/drivers/xen/xenbus/xenbus_client.c
> b/drivers/xen/xenbus/xenbus_client.c
> index 1a2e0d94ccd1..7b1f7f86b6e5 100644
> --- a/drivers/xen/xenbus/xenbus_client.c
> +++ b/drivers/xen/xenbus/xenbus_client.c
> @@ -433,9 +390,24 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t
> gfp, void **vaddr,
> goto err;
> }
>
> - ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
> - if (ret)
> + ret = gnttab_alloc_grant_references(nr_pages, &gref_head);
> + if (ret) {
> + xenbus_dev_fatal(dev, ret, "granting access to ring page");
Can we take the opportunity to unbreak this error message? "%u ring pages".
~Andrew
|
