[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 21 Apr 2022 15:02:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qa9f+bBLd9Ya+rQZ51gVN9YFWARxw6AJJLnAp9CF1mE=; b=lYi1i3GxT038jqeiKtuCUcRYWmhk5ccBn4Qp1oC4TXcK/cYHLPGYtOPW7NGqaxITFJqoMajd0bRckhWdqyik7kWgu+fwNyhMvULVEZX4uHdZy0xB1aRdhqF87JKanwcbqb1FsJnc9b6K22/JsDGmN+ZfwjvwD4fwlZ+Afeiu8aHjEXwpsUoGZUfqQ87FL9GPGewP1Y95uVC/pjMwy2oAPZNXbBOTc5l/slCaKdifFI59UGs99qFn8vL5YeDxqhvFMYM7aaLCa5SzooQbhhcRtVPHMrEPuaXbovGC18F1HDZu1duH9fFpn05pyKxTuPwuc2yBvRy9zn7ta1RO1FL3jA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YgvSWJPx1+7FVVTr18oWjqWN/O/EjwX9xUKfl+TQ9ac5FVops9cr5ImGWPx3tImwTrtZtvdE9JLpNxDUeCtCh2Az5VI9NAtrexvvGkwtF47AOpIMLku1odSA2J9B3aVMAZ8dUgZngf6mg+A30dIIZZpJ32jw7RQPGHBJNL+/hjVNoxIj+bMVA94/8c4rp4/pKsMMLJOQKw+vQIyn6xRJLj2JJsxx2JBSP1n0Hnzxjnwpp5Rd+HTZEKtiJANaQDdJKvduV6ohMRN0mGL73zgxsAWjLXr8Wv4LR/Ghnl5Th/pMWsLlBv6ZQx1AQv4OI3N4l9PnrjOmXRkLYMxn/0dc6g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 13:02:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
>
> debugger_trap_entry() is unrelated to the other contents of debugger.h. It is
> a no-op for everything other than #DB/#BP, and for those it invokes guest
> debugging (CONFIG_GDBSX) not host debugging (CONFIG_CRASH_DEBUG).
>
> Furthermore, the description of how to use debugger_trap_entry() is at best,
> stale. It is not called from all exception paths,
But on almost all (before this change) - the exception looks to be
#NM.
> and because the developer
> is forced to modify Xen to perform debugging, editing debugger_trap_entry() is
> not the way one would efficiently go about diagnosing the problem.
Shouldn't it be the remote end to request which exceptions it wants
to be notified of? If so, removing the hook invocation isn't very
helpful.
Jan
|
