[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 21 Apr 2022 17:29:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gQFfY2t396L6hNff6hEfdCdFQEnDCW6uEEb70wyU/s=; b=TB2Eb6E4hgPBb6DRAqdOjOnuvj/ZqYySGIPbOHoOHg/YGwNMoHoYfGtsHGIiyDfFniKcGHAjN4YYUva5SLXczs5zFoRA3J0QBc9hlW6C3ztMKL5RvW10vMl779u08k66bHhHJuT+z1vSMrbwTiRRq4Gi90HlB2JUB1l+p6AXreHSemCAsEccUixZatYU5JlT46SHnLmk/SnijXfxvJlV0F5beuFYlVQZOAGJL4sM3gcTP/N4LTsdahHg5Qblyd9l0He4yOfZ57zOUClAAGdsdQPkfj3U4W+YOk6NR9GTx89U2yD1nx28o9IeOL76VdXxJt9So3MVPpt5GLq3uQVuXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJ2m3wH1UPdYKexo5r9+C9Gtxyr1hQysMbcWFtGFQLegbj1RsAwt2q81/AXfbM5B0WJ0bezhNESd6/h+g8LY8HnX1G1ZGTXUlwoPyAMXoKvLGVISB7kiUnldhI6HsKOes+msKjdDjITfNvvhWl4BACvIXH95S3OFimy73pgxoQx3TnUVAtB0s0MoOXCQecGWWl7iwKvihURsqubrDQZhQT+pQVaLupwu22wz+AAMfKKMSDDzsVGUwqqjbcg/DPpac9zOAvOOzJUV1bFs/ywQlwXQahHfDAQrUhDS1HRys1piZbPJycsbPhm8Jdt2T5yk/Cn+8Is9sJ8HBJCC5kK2Eg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 17:29:49 +0000
- Ironport-data: A9a23:whxG/KvoZdtlTDWLAGr+uNErYOfnVENfMUV32f8akzHdYApBsoF/q tZmKW+Db66JNmX8fd8nb4i/pBkDusKGx9RhQQU9/ipgESoa+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/X4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8NPo30pLsxVCB4TT16IZF96bTWJ0Ow5Jn7I03uKxMAwt1IJWRvZMgy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5u1qiiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmLl1wpgOmF3Nz9YOShY+4Ewkahg kn072SiEEoEBt+f4G/Qmp6rrqqV9c/hY6oQHrCl8v9hgHWI23ceThYRUDOTq/6zgF/4VslfL 0ER8ywGoq079UjtRd74NzWnpFaUsxhaXMBfe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBONB0mLicSHbY/LHEqzq3YHERNTVbO39CShYZ6d7+po11lgjIUttoDK+yiJvyBC30x DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlddCtn/No590j5EWQ==
- Ironport-hdrordr: A9a23:uT3N76u5ucWHM8yZLan1MHqh7skCL4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP v2MI5KApbYXB7TJbo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVMDYNMJuqSTXg0Gj9wXP4qElXaz6V7UAgABJhoA=
- Thread-topic: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
On 21/04/2022 14:06, Jan Beulich wrote:
> On 20.04.2022 16:13, Andrew Cooper wrote:
>> From: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
>>
>> debug.c contains only dbg_rw_mem(). Rename it to gdbsx.c.
>>
>> Move gdbsx_guest_mem_io(), and the prior setup of iop->remain, from domctl.c
>> to gdbsx.c, merging it with dbg_rw_mem().
>>
>> Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
>
>> The semantics are rather broken. XEN_DOMCTL_gdbsx_guestmemio only sets
>> copyback when there's nothing to copy back, and skips copying back in the
>> -EFAULT case when the iop->remain field is relevant. Furthermore, it can be
>> asked to move up to 4GB in one go, with no continuability whatsoever.
> The last point perhaps isn't overly much of a problem for this specific
> operation.
It's also not terribly hard to fix, but I really don't have time to get
bogged down in "make the gdbsx hypercalls sane".
XEN_DOMCTL_gdbsx_domstatus is a disaster, and there are far better ways
of doing this. https://www.youtube.com/watch?v=osZeioYKsxA is one which
was presented at XenSummit in 2019.
~Andrew
|
