[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 21 Apr 2022 17:51:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1vn/PgBwFiDyetdTn8eGwhnUC3ObMABA8btvfgynp7k=; b=McY5aTJc5od6p87FbsOd/GVf30cKJRkAp4dXHUX8KXzH2+IKRLqHT7Y1y5DkeNHVIqeIwaeDyjlSJDUqa6LzdGQKjoZEFbwNf56yT97mrUJyl/D6ACMq61OdQolI9AenFELsSqgcKLwqz8mt4NKHx9lZIDT+6T/1Hmq3BsXvNwKeB54xYe2/R03Af3+11VftQK6Gfk2CwsgU7djjPLXPLmI8L4KbHQMYwDLzVZqtbaUMsaTuHms1MoeI65XhMmmz9KfUvduFHnXty/BTgq1O6vEU8StACD6DoQx3DszC+Z5mhIfGwoQj4gzW8e2nEOUTJ2S2aQ0c97f/n1isisCLFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QenYwEKeYmXpmfrTkDYXCXd0hrRSk2xKSqfJ6Njujf46Un3o7C3AdLP/NbbMNrp1oALynLksoep4hqKRzWMBs/5e40nh20a3Ts3L2yNXfiBJy3PgHnaIsJ9ll9prgDPrMF31QNdk1RK1HMRwbRfNVcytd8ttqAIGpXryEPtlI+7EYeOryiVXlRzLSr/0SA9uyxDU36CTG4/T8iCvolmYfLGd3K7kNx/wCtVSBxPikCTuutEJ0TaokLlzjcB07PjOK0P/Ec085EMNjK8a+fpy796UMu1E7YrUCrohdpb2FZJIbZUUONFqVd+0Lo9rCezFhpvP4hFklzj2PjxypSjyxA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 17:51:26 +0000
- Ironport-data: A9a23:F7gVSap57BXUvnuiB0AeqM/69rNeBmLvZBIvgKrLsJaIsI4StFCzt garIBmEPazbMWv8et1waI209RwEu5Hcz4JjHQc+ry9jRXlH8JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvR4 4qq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBB7zAxeYSbx5kEQZjBKMd4YfiIUmHiJnGp6HGWyOEL/RGKmgTZdFd1sMpRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkHh3Fs26iiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmLl10tiOaF3Nz9fIbSWPhJrGChg l3/0TnlBikwPeay1m/Qmp6rrqqV9c/hY6oQG6e/7eVCm0CIyyoYDxh+fUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxaspQUAUtBdF+k77gClyafO5QudQG8eQVZpasEitcIwbSwn0 BmOhdyBLTZiqqGPQHSRsLKdtyqvODM9JHUHIyQDSGMt3d7np40iiwPVefxqGqW1k97dFCn5x naBqy1Wr7cZgNMP1q671UvamD/qrZ/MJiYq4i3HU2Tj6Rl2DKa9bpGswUjW67BHNonxc7Wal H0Nmszb4OVQC5iIzHyJWL9VQOzv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf XPuhO+Y37cLVFPCUEO9S9vZ5xgCpUQ4KenYaw==
- Ironport-hdrordr: A9a23:AIHvKKkDFfpNu02CphWEIOkZDRnpDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe q1NdZfH+LjRFGebLp04w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVHuOvzYJLKPprEuLadRqUVZq9az6p9GA
- Thread-topic: [PATCH v4] xen/iommu: cleanup iommu related domctl handling
On 20/04/2022 06:57, Juergen Gross wrote:
> Today iommu_do_domctl() is being called from arch_do_domctl() in the
> "default:" case of a switch statement. This has led already to crashes
> due to unvalidated parameters.
>
> Fix that by moving the call of iommu_do_domctl() to the main switch
> statement of do_domctl().
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
