[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] VT-d: fix !HVM build
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 22 Apr 2022 11:42:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y0PMjGop8+FVS5FTxtKmASPWLTlZSPYPyMYXZwy2wBw=; b=SGEfwEVRb9tmgGT6HCgAwWfmnaP7ukPGwkqnJPjwHXrsXTlyqEs6teJaJ0uGwF9MoIXHGhXdQTlkjDdCCk9bZYZxtP0a1WR6UbcxyP8rrKW5eBc5u/0UOJ0x/qatT2j6GqusP19fHAIfg9MvXeojC5kCRqCUo0biQHyq27sOQw7TXftYdG1phj+0FvMr5lWj35bw5+eiOza5abMPgYoXMkFVEE/9yf3NPbrpNKvCUM7ZN0XxWn00FlXFa/L0eosX+zFnaD8RYL3xzwTE92nUnPeyxHTPbCrK1k9i4+qEbTyqwUQbVUsQwApJtdKaiPK22rnvD+ZPy2o7EfJxizs4+w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XgL2qmYSMqsV5sSuM8WucIII8RvZOMzqlJwH5PdKxQcStG1nJTyOjY+bWmdF+lae4D1/cXjpha6nl3cooiYYM0aWPN63Ul6rXTeL6YBW0qO24dyw0Z5BjVJYAW4yvvgJSUhulp75UEXEnEBM3bj4W4Fhehy0fo8vydZ+jeKlxK5UVdAE8wp3oGWouBAjGrHfSgDUmkQGvoLzGa1khxJQQNrvEv55bISMZ3FOcRGljZJYuG59tQTa1jEukwFJwB+HgVx4GGeLcbVRZR7tK7fJUERwWwSaH2Mdi8Sl9AmuO/pJLMMe7ELVo22r+L+no99wLJmmVJ21FM1EXHbbi1s0vQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
- Delivery-date: Fri, 22 Apr 2022 11:42:55 +0000
- Ironport-data: A9a23:MWF6Rqg2WiKr6+eVkyl5OrpoX161ZREKZh0ujC45NGQN5FlHY01je htvX2mHPv2PYDGhfNt+Yd/n/UsO65+GzN81SwRurypnQywb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nX4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YV8kD4flhtonbzJ3SjFBbbZ43JqAcEHq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWhq7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJpsjeKl1Iti9ABNvLrfM3SQsVbl32h/ CXX4X+hBQwwG8CAnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslh0RRdtWVfE74Qely6zI7gLfDW8BJgOtc/Qjvc4yADYsh lmAmoqwASQ16eLPD3WA6r2TsDW+fzAPKnMPbjMFSg1D5MT/pIY0jVTESdML/LOJs+AZ0ArYm 1iixBXSTZ1K5SLX/81XJWz6vg8=
- Ironport-hdrordr: A9a23:ycmwzqqTz3JmJYNHBRF0J6EaV5t0LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcotKLzOWwldAS7sSo7cKogeQVxEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZi6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInBy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0SVjcVaKvi/VQIO0aaSAWUR4Z /xStAbTp1OAkbqDyWISN3WqlHdOXgVmiTfIBSj8AbeSITCNU4H4ox69MJkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pUVFb/l/1swKp5KuZIIMvB0vFuLA CuNrCo2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+ jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMNIYDaxfzOWzGu/HQ0Mk3E4ncR+ u5Po5QDrvqMXbucLw5qzHDZw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVi+clO+iJmB//EeiyYBjieMG6Kz7z7+A
- Thread-topic: [PATCH] VT-d: fix !HVM build
On 22/04/2022 10:58, Jan Beulich wrote:
> EPT is of no interest when !HVM. While I'm observing gcc11 to fully
> eliminate the function, older gcc's DCE looks to not be as good. Aid the
> compiler in eliminating the accesses of opt_hap_{2mb,1gb}, which
> otherwise cause undefined symbol errors when linking.
I've just reproduced it on GCC 11, using CONFIG_UBSAN as well.
>
> While there adjust types.
>
> Fixes: c479415610f0 ("x86/P2M: p2m.c is HVM-only")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, preferably with
the commit message tweaked.
|
