[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 22 Apr 2022 14:59:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMv2Mf3HbKb0S1kBCFIVNZS23nc51ueQKQ+r1qjJMw8=; b=HmjgcXfhh52aIf+lD0RLiLn8456uCMGvJAQ3kVVKYjMbXMVwRp+hhrcV2DtRpPMGWDsgLwIkTmx6JjsUz3OAjBlzQm9CMhkCamoY8WW8wIJkyNDVAb+XahxKD3r39KCF9yc/Br7ZsLos7e1qzzR8zk0VyvEHOwdmwQVZNjorTWX9yO1hgITkwCV+17bVzqYgMCBphJsCkPCiGIIlOWV4teL4eXCnlfUkcas+v20g4HIWSa4RXnXe1t2Zbk65k7RcrqkBHLj1bCB+/xHKcRxc0yv2mRoEq84YqXSyMcmXViU5RJqAOtptpztE3JGALuxE9a6hUbpVT1C3wCD5FNaXew==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h7CifjANm3gQTEBerVtj5BRhS3h6+YMHzK/uSiBx1gdggFnEmyF3dcdVqLc8P/xqtqxKVjzWOR2iERtyOFTZi5TUCyPjBxoN+Fe2WmnS6AwNkUZ3BNCgHrQP55hSqfFNpxthviXS5VLW6eY1kvGCPKV4S6UkFAfd/HMZ6CpC9m7IGcdk5grd5sn//rCjVEzsTjzlCyuwfJQVtAcC+439Hevwn9VMYJGmbPOdyz8XsBroLseg6P/CV0sTON5/QS1NwcQRGWBqmbE9KmueU+4EfH684+adIgyfH5JuCpJXOEDi/pjTmjzqJdmFrHkbzHn01Z3R8m5NJ10m2XKRKnFo+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Fri, 22 Apr 2022 15:00:07 +0000
- Ironport-data: A9a23:WHXPuq0FL5EarR4dz/bD5dBwkn2cJEfYwER7XKvMYLTBsI5bpzNSz GEaCDrQa/3fNmr0Kdoiboi0oBsCuMXXzYRnTVZppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIy24Dja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1q7riRFQIwOZbJkd4jQysBQj9iMYZvreqvzXiX6aR/zmXgWl60n7BCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfmSjTNb9G5YasRmNPDSf ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUG+Q3M/fdqvgA/yiR+6+bcAvuLVefVSJV6hhy/j U/E70rmV0Ry2Nu3jGDtHmiXru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJvHiWzWorXjCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Z8hMcOscY3QXkm0 wGPltaxVTh36uXJETSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa3871KbnC43TEYj7vg+R
- Ironport-hdrordr: A9a23:nCTXiqGfrM4vX1hBpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVIin9iN+mLKty0OtvWT3B8JHOKz8CCWAgAAA2gCAAAEygA==
- Thread-topic: [PATCH 4/4] tools/libs/light: don't set errno to a negative value
On 22/04/2022 15:55, Juergen Gross wrote:
> On 22.04.22 16:52, Andrew Cooper wrote:
>> On 20/04/2022 08:31, Juergen Gross wrote:
>>> Setting errno to a negative value makes no sense.
>>
>> Fixes: e78e8b9bb649b
>>
>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>
>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Do you want me to send the patches with the Fixes tags added?
>
> TBH I didn't bother to do the research for those, as the wrong values
> don't seem to cause any harm today. I just stumbled over the issues
> and thought it would be a good idea to fix those.
Given that there's nothing else to adjust, I was thinking of just fixing
them on commit.
But we should backport these to all appropriate releases (cc Jan).
~Andrew
|
