[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] x86/mem_sharing: make fork_reset more configurable
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Apr 2022 09:49:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0eZOK6t0NMZu8QXih3b2xtzSHrOqoaouXI0M5kS5dg=; b=RlS+WfEyZpHWeAeviTgSApVLHrDlVBlJwjXrACDrzDDUpUkZK5SK2uKTNgzA+NcxucA/LlQUE07GlBDoADXHvSbHxMwRSvHfUGMPFTh50h3qwKbDj6yGSB+GyTjBEi2gSiSBswu/iX0lWA3TClJrV03+sFmPD5OiLEL22LNAqKkPXfVFem3ebHLNoF+gIx2kn6T+Xscs83Q2Bl1ERAS51CIFpeNv2r67Ppj6dN4mQSxQRJmw/OzPsJgQQ+9VfEX7fuLpliUKvMh1eMW65lAwUWofJ2xl4Oem1Qjig7R7zzR3AnLoGg1r0F4PCh64Gc15+bMdSLD9LwKX3h6msK3vEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljca6kbRjgeljQtJvqMq3szsEGuUbD3QBqkekhqGmAIVXXkzX2szg3srjQCl2m+owXNryTRJ4Aqgz9eGd+fy5CZJxfHeuhHU1l4zzajRpEwVktdy5r4Nhy2HHYE3mFeqUzaGNaPE9AoH2wMG0mWMC+5N5unu1+LGPl8qryOwbaB6DgPWv4FkLM0q83mmLGT7kRX27PowP0J8VQXQF50LCB+gpKH4ohe2ld+3c/xULl44kyQVdiGfStEgLclA2gp5YKw30Wi8hIvR2v+AwnhBqb3Kob+7M++FrRVihGYMJeWFnse8aeCHajrDxPxGogup1vanB7+zzW7EpK7Gh9TGyg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 25 Apr 2022 07:49:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.04.2022 16:07, Tamas K Lengyel wrote:
> On Wed, Apr 13, 2022 at 9:43 AM Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
> wrote:
>>
>> Allow specify distinct parts of the fork VM to be reset. This is useful when
>> a
>> fuzzing operation involves mapping in only a handful of pages that are known
>> ahead of time. Throwing these pages away just to be re-copied immediately is
>> expensive, thus allowing to specify partial resets can speed things up.
>>
>> Also allow resetting to be initiated from vm_event responses as an
>> optimization.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
>
> Patch ping. Could I get a Reviewed-by if there are no objections?
Hmm, this is a little difficult. I'd be willing to give an ack, but that's
meaningless for most of the code here. Besides a stylistic issue I did
point out which I'm not happy with, I'm afraid I'm not good enough at
mem-sharing and forking. Therefore I wouldn't want to offer an R-b.
Considering the VM event interaction, maybe the BitDefender guys could
take a stab?
Of course you'd then still need a tool stack side ack.
Jan
|
