[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
- To: Julien Grall <julien@xxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Apr 2022 10:36:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VxNmv+Qb/xUW1DVBPzy4gL03WTVj/O8Is4qts9N9Tys=; b=AyvzC7u835b+mD8n0ddEbH3ISP8tYQ1J6A4EYd/o/5y8E7/MYnXw76K1L1e9gyq3Rlss8aUcrVp32+O/EOJ//nu3puHiNVxeGiUOEeDCoOcHghcmnYax5l6l+wYNcS/b+9c5Vo7OVfgHXgM6jVgo3T7PkQAljAc62+gI1hujwZGDgm0IG6QZlrfVaUCLB+4IbVTJ0hcxXGSG/MJXKk2ePIJJjhKk2hItsvOx089i1jkQUS2pgTgmMwqj2gmBppti1L7qp3P9fkfka0q8cvaPEumnjgRU0R8QskwL+zgbgAtFU0z+MQzmTj1jCZ/8IFDiet/7VbpON4fC3QUoutvJ5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoRq/TrnxBnBcE7HZDvBiqVDPDxHzbr/mIcowe0auIr1814kgJLaRq90jGjOnVxZruQ/sowY3UoE2SKjzpyhU6v/n+cmg5SaNyYmhOyI5yuqbADWxUhn34PM3CXPxf6O0T76oP9wNK3g+twf+o0cruV7ZlFOYClV4IZUtSI2CtxEkRR4P7rxrHMw2UlZPA5pQ7pMlhMus/9vADHP1clOo4x9HpKjiOkRE22sg84p2M9HcKaFHCjcNFQwT2lnOQVTekQh6zCtVbeH+GBK1pUnx1ZP7q3noPZll/XNacNpyUKELz4dc3DM13NkZgpYlBclGI7Wl9eeUtyKd/BYubiftg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 26 Apr 2022 08:36:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.04.2022 20:32, Julien Grall wrote:
> On 25/04/2022 15:13, David Vrabel wrote:
>> On 25/04/2022 14:43, Julien Grall wrote:
>>> On 25/04/2022 14:37, Jan Beulich wrote:
>>>> On 25.04.2022 15:34, Julien Grall wrote:
>>>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>>>> --- a/xen/common/page_alloc.c
>>>>>> +++ b/xen/common/page_alloc.c
>>>>>> @@ -162,6 +162,13 @@
>>>>>> static char __initdata opt_badpage[100] = "";
>>>>>> string_param("badpage", opt_badpage);
>>>>>> +/*
>>>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>>>
>>>>> The comment needs to be updated to reflect the fact that at least Arm
>>>>> doesn't use IPI to flush TLBs.
>>>>
>>>> I thought the use of "may" was satisfying your earlier request?
>>>
>>> Maybe I read wrongly this comment... To me, anything after 'which' is
>>> optional (it is a non-defining clause) and describe how the TLB
>>> flushes works. So the 'may' here is referring to the possibility to
>>> use flush TLB.
>>
>> Oh dear, you're using formal grammar with a native English speaker who's
>> never seen a grammar rule in any of his schooling.
>>
>> I think this should be:
>>
>> "Heap allocations may need TLB flushes that require IRQs..."
>>
>> i.e., "that" instead of "which"
>
> I am fine with that.
But that's still not necessarily correct. I've gone with adding the 2nd
"may".
Jan
|
