[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
- To: David Vrabel <dvrabel@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Apr 2022 16:01:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rw5u93cJDYWEddNdIN73iKCk9IJj9XNE6SNSWcsFc40=; b=EDwtknJUCUhg0XbX1GxBFJu9mYJCEXkC4re3Y1Xfi7GX9bNwka7JwTYSOzSNj8cnnpy3i08E5X99SDnH87Mw7DFrreeyr5AnJqqa28yLinxlfNZA2Ov+8E9Rhezw/SiMGPKRFM8RYqGueBjeyCRuE9k4li5DHQSnmHQnx0quRHrjFh8mr25pH9DLhCQXGIWd53EBD/1ZfypNTkHk/q7OK8jgcupnHUVadB8T3r+AenMD0I8JaveEFiiJfq+sI5JhRctR4PMweOtm3OSRwvrmZVjNbyGf6YBoZLDrnfADI9B8lTC8vqnNsmqDS9ZbmiSAmDivXATd+WtRavLjtHNpEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7+xem0bp4A3ntgLamZHeH1a1VCrW9XGxjfp4G5AA7DmHpEzyQiJ5eRqe6tN6MdpG5xqW8vdizWty6KNjAzFObdqAwB132o3PgMI2fPQac92eb/AjVZQBLdN9PuaWWGQrqN3yWGqJDgf0kZlCp7OcUWzxvARPafirRF+8cwIHuY9DYw/0O2sXWSPJtCopMvr3XCbVwEF/uWFNfj7RaNinVDA8CGMnchpIWF8AmVOzpgHlvEYRfQmaw25wBqeh9HIcPSB8lsaGY3kNiXEDRRLb1FtwSK2JX02UQGjIgJnPMC74nBqfK9cwCnxMGBLNckHC2dAUlcvb4CvR2eQkioZbg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 26 Apr 2022 14:01:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.04.2022 15:28, David Vrabel wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -162,6 +162,13 @@
> static char __initdata opt_badpage[100] = "";
> string_param("badpage", opt_badpage);
>
> +/*
> + * Heap allocations may need TLB flushes which require IRQs to be
> + * enabled (except when only 1 PCPU is online).
> + */
> +#define ASSERT_ALLOC_CONTEXT() \
> + ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1))
At least one of these tightened assertions triggers on Arm, as per the
most recent smoke flight. I'm going to revert this for the time being.
Jan
|
