[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/10] xen/x86: move reusable EFI stub functions from x86 to common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Wed, 27 Apr 2022 14:26:50 +0800
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=temperror (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=temperror action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=; b=Hl90H58MSVD3qq0Kc+L9M/xI8lTDinF7JsvchLfGVcOI/59j1KOUkFH0hq1/e3TCiYz6nQ6cbKX/OpAninAMF20b6YWNwuny0xjM431V183YfstNy0XMkVKOIql37ClUDgp3mwts2nHBs2JvvGeiJoiN5U4nl/rbSeun83Kc6xLMw5D6rNwmf2DvlivL72VE8CBcCO1ZFSeA9NGUmAiJ1SdIo/t/nfbgIhxCerpHPthKjN8v1sT3FmspMNaFfbOfcxi/DqEGPmEJBGQZugaMMq9IyhCbS3UDv1Y0ng+Mem5rMGQ6Q0XbYrQkIacVs5bi50B9OzXcv4ZBS9B7Wxkhcw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I5h1RGpd18C//EniB6JdZ2FKRhqfZ1+dLqJqi6X25ds=; b=K3bmFASUNXy24Hq2EaS1/YmM1dFtxzgmpqlmkU+NsV+8tbcdjTm5e07WgiG5VERQyTx+/gCxjg78F/lJI9DsYoG+/YNQC4T+bo4+b4dBisFF2WDrvVMcARTB/f1snB3WBQPEmPExLsSt0myXzzz7AE3++ihQ6KlS4LzKAqitSKXzb8ikH5DLTMw0v2Q9qpku/WGAJWGmPhPFK+k2T9jRexalWJtkrUXuZc8y5Ol6TdLb2fd2psmFGhYVnpKQe0T4J43JFJyd8MExyHa1dm6naG4ZEgw4iU4XYeVfeW1KWglXXoOYyLIr7FrVYhAS63/P+ec2hOvWZP0kQBLYJAIevw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JSbA1aE6Na+q1MZ2qXsAPt0LwtSFphwApCVi1Nx+yG87IwkBs7ng88vQ7yEfXo92Gni9hZRTzZqSwjWz6KSul3RbfQWZY/FBTxLHYp0bvYnepotbT3q02JDX1jjxYniX7cvBVGdRbrhCrAKARtQe8BrV7QbA+C0oiiy9SsoilIOyMNCLNU8ySvFrMWErozBS08o7qqXeGgh3hMhYcZ5/b4iUhcTJCPREuv7H00umQJEeJ8E5R9ChsSLt0J2NT/aJcGONZV8fcuMBcU0A55ojqxjR9ADoZwV8y23zNJrHyVtYRFHuj01lqUPWz0A/YrShsGIPd8RpPt8yNHiL2Wwwzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOpknIYWaqYv2GCHOdyfmAuVUD4L9itzCSO94eOgHTP03OYMlq6YslHNBn/sz1A9dXAwP1VMVeyTRoRv4Z1nX6p187TSXCIk0lvv0Ttqc/5ZHMkr9jYRxXqdDlqTrLELWwvmyKjeKLeayIWA2C7Ug3tjkEOAU2d+QkzjZGhf68lKw7UM6AtEHc4Qg1LkVd6nJeCjrfix/gLx7n7hz/Zzi7Q19CAVutz1o0Zn0l98TPBvT16zh4xqOwXqaDShqMPdtgvMw0NjVr3mdhSFfViisPAl9W9mTPC+b3Qbx7ZDSaEucQ3HRbN1sBUU+02BK9cSLZzSCUtaNIloVMl1RM6Aow==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 27 Apr 2022 06:27:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
Hi Jan,
On 2022/4/27 13:54, Jan Beulich wrote:
On 27.04.2022 04:56, Wei Chen wrote:
-----Original Message-----
From: Jan Beulich <jbeulich@xxxxxxxx>
Sent: 2022年4月26日 22:31
On 26.04.2022 12:37, Wei Chen wrote:
On 2022/4/26 16:53, Jan Beulich wrote:
On 18.04.2022 11:07, Wei Chen wrote:
diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub-x86.c
similarity index 71%
rename from xen/arch/x86/efi/stub.c
rename to xen/arch/x86/efi/stub-x86.c
index 9984932626..2cd5c8d4dc 100644
--- a/xen/arch/x86/efi/stub.c
+++ b/xen/arch/x86/efi/stub-x86.c
I'm not happy to see a file named *x86*.[ch] under x86/. I think the
x86 file wants to simply include the common one (and the symlinking
be suppressed when a real file already exists). Naming the common
file stub-common.c wouldn't help, as a similar anomaly would result.
How about using stub-arch.c to indicate this stub file only contains
the arch specific contents? However, we cannot predict what link files
will be created in this directory in the future. If someone needs to
create a stub-arch.c link file in the future, can we solve it at that
time? Or do you have any suggestions?
I did provide my suggestion. I do not like stub-arch.c any better than
stub-x86.c or stub-common.c.
With my limited English level, I can only see that you don't like this, but
I can't get what you want clearly from your comments. I can only guess:
For "x86 file wants to simply include the common one":
1. Did you mean, x86 still keeps it stub.c and includes all its original
contents. The common/efi/stub.c link behavior will be ignored, because
of x86 has a real stub.c? And common/efi/stub.c still can works for
other architectures like Arm whom doesn't have a real stub.c?
But in previous version's discussion, I had said I created a stub.c in
Arm/efi, and copied Arm required functions from x86/efi/stub.c. But
people didn't like it. If my guess is correct, I don't know what is
the essential difference between the two approaches.
2. Keeps stub.c in x86/efi, and use it to include common/stub.c.
I think this may not be the right understanding, but I can't think
of any other understanding.
2 is what I've been suggesting.
Got it, thanks!
Jan
|
