[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 27 Apr 2022 11:00:01 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sb514sV2BkgQgmqKHrSdZIm03KhAsgFYXTM0bUtyV4Y=; b=BgV3Cmhvse0dqK0C1AjmYHdWLLIXpbBZC6xRX111BPzZj/RkooGurrawaVbSLSZWcg+PT7GA27U7roc7pkMC6DlY1k+ZCtsp91Rp/zxSJ/gBrSq2ZpZ+bK67EOI2Q+EE6uCgOOidRLKwgVVbX+gD3J8+M7XGAEvzwVcvBlRKSmNzh1+OuPTG2iIO45lskYaV4dbGjn5fxjzB4EQs9CJjNbWd4lAjC7AR7ITca+/OwkvVP9sAIuM/G2EFAAHxVAb94AkAyJb49QutdglZ7Wk9bVGOTcN+fCAdKPIhUydfIOlNkIcrrpU3JBG7h4266KQQ3rtUSLPcjUiVk3yfDyp8mA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJJBVd7w63y8NtH9w+EqK5s86kk3aD1Ax5KmmuzMs5hDcozecR50+RCz4Evjz+EZIO2h0WSvZKreNmJ6K6lcc980Eu2fIJFjzpcUDQxWZmrW4whpkgrjh4HVlEu0PX+PouZejx7d3x0MkHno9MT+eWjReswJUCmLsgKYO/yMZoSnn50NWPuHG2hUVuKpRBVIAkD93G3Lwiv4qzs1I5H1h+9RxuZE4Cr+b5/TDun2tywFkbaQVWCIGp/0SDoKoyGz8Shi6tlDaj4bkCLNqlqjGWGRLf6j1V9z47nnkwCXJX5FGBwjEX/1W9A3s3GFugOoXIkad4ydpwHn0XrKavLoWQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 27 Apr 2022 09:00:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.04.2022 17:40, Demi Marie Obenour wrote:
> --- a/xen/include/efi/efiapi.h
> +++ b/xen/include/efi/efiapi.h
> @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES {
>  #define SAL_SYSTEM_TABLE_GUID    \
>      { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 
> 0x4d} }
>  
> +#define ESRT_GUID    \
> +    { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 
> 0x80} }
> +

I'm sorry, yet one more remark: This should go here only if the gnu-efi
package also has it there. Otherwise it should be added next to the
other GUIDs in efi/boot.c. This is to make updating of this header from
newer gnu-efi versions as straightforward as possible.

Also please once again use the name from the spec,
EFI_SYSTEM_RESOURCE_TABLE_GUID.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.