[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] mwait-idle: add SPR support
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 27 Apr 2022 13:39:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZrcf9kLv/d52n7gJCUeGAp31IHwN1zUO+wj439yMcc=; b=gW/TRey1PhnOYsmFuIRhf257vSWLyyegcD52RcCUJXj0ksEwFVtDT+oEwCyMxCtY2/W+mluiBhwKc4gtyAf8Qf5CoCHhN8fLwGbKXZnzYe8wKD9CyQ/LqVVpmSkqEbfBfiL/pzvFbl1oNZgIqSXpbXDXtaA9kp8tSvoomZVP+gCiI3RiKCK5quQqRF7fu8RiE+4NAgwXStu1oyD28z+Mtcq0YmL72XCgxV7o2IrB54iqTRxvbjesiT1kUZSkTrVCg+9wGckY9Kf5a8nyO/zXNuwss1td6lplLBMG0rvIdYyaHJPWLXKzag8v3rLnOX9ffMnN+Sl9SaM6GaWsBVJTrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVBy74tPO57BVaSDTptol90ItEvFbmjnoXBI8RXlTGFVu4O63S8+DS5DvoxHyDz1/izPCWakaQzhpfWbj4dHtYhaIYogHF1yJOLSudPCDjtStxXlJmDaomKoh0J3O291yoiFzYGYK4b/Y6Kd0uvs8ALamZ9AJ9rws99qybKlJJ+nw4YexMrS2a+LUmR/cJMUHUYz1REI+7tGz0MwRLE2QMEn05LZV6h0iONWYKxFNDdpzdkBn6Jb8D/zinp4tswc69S6eklXIND0sdnCFPm2Trw62dswsxy3nFetmBtbVPqCB/VkQVvb7zE8T7c7V/JFEmy2EcLrsikpjWvBuoLcMQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 27 Apr 2022 11:40:15 +0000
- Ironport-data: A9a23:ep2mhqgGLUTjz0IGOMnBAefSX161FREKZh0ujC45NGQN5FlHY01je htvUGrTOfvZZ2Wmfdh2aouwpx4AuZLXn9NjG1E//Hg9Hiob9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1nT4 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQMoBPOPquYbbxljCyI5EPBh447oOHfq5KR/z2WeG5ft69NHKRhseKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMu4EegGlYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+QPM+fBnuAA/yiRNz7PGaNSMJ+WVBtRkhmCm9 lzW5GDAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwK8iG6JuFgbQdU4LgEhwASEy66R5hnDAGEBF2RFcIZ+6JFwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ==
- Ironport-hdrordr: A9a23:68zpQ6EUQxIJa9jXpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 26, 2022 at 12:05:07PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
>
> Add Sapphire Rapids Xeon support.
>
> Up until very recently, the C1 and C1E C-states were independent, but this
> has changed in some new chips, including Sapphire Rapids Xeon (SPR). In these
> chips the C1 and C1E states cannot be enabled at the same time. The "C1E
> promotion" bit in 'MSR_IA32_POWER_CTL' also has its semantics changed a bit.
>
> Here are the C1, C1E, and "C1E promotion" bit rules on Xeons before SPR.
>
> 1. If C1E promotion bit is disabled.
> a. C1 requests end up with C1 C-state.
> b. C1E requests end up with C1E C-state.
> 2. If C1E promotion bit is enabled.
> a. C1 requests end up with C1E C-state.
> b. C1E requests end up with C1E C-state.
>
> Here are the C1, C1E, and "C1E promotion" bit rules on Sapphire Rapids Xeon.
> 1. If C1E promotion bit is disabled.
> a. C1 requests end up with C1 C-state.
> b. C1E requests end up with C1 C-state.
> 2. If C1E promotion bit is enabled.
> a. C1 requests end up with C1E C-state.
> b. C1E requests end up with C1E C-state.
>
> Before SPR Xeon, the 'intel_idle' driver was disabling C1E promotion and was
> exposing C1 and C1E as independent C-states. But on SPR, C1 and C1E cannot be
> enabled at the same time.
>
> This patch adds both C1 and C1E states. However, C1E is marked as with the
> "CPUIDLE_FLAG_UNUSABLE" flag, which means that in won't be registered by
> default. The C1E promotion bit will be cleared, which means that by default
> only C1 and C6 will be registered on SPR.
>
> The next patch will add an option for enabling C1E and disabling C1 on SPR.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 9edf3c0ffef0
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
