[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in
- To: Thomas Huth <thuth@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 27 Apr 2022 14:38:45 +0100
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <qemu-devel@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, <kraxel@xxxxxxxxxx>, <qemu-trivial@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Wed, 27 Apr 2022 13:39:09 +0000
- Ironport-data: A9a23:YUFkT6NsV8N8MLXvrR1El8FynXyQoLVcMsEvi/4bfWQNrUp01TBWy mMeWzuGaf+KZWagfNl0bI62pB5Tu5KHnN5lTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NEw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1 tISsr6qRjUQHffxn/hNejBxIz9XMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQTKeEO pFJMFKDajzyehFwPnotCqgap7aMqViiTzFKknWs8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTQY8XCfik7P90gVSX7moUDhIQSB28u/bRola3RtZ3O 0ESvC00osAa71e3R9PwWxm5pn+svRMGXddUVeog52ml06fR/kOVC3YJShZHb9opstJwQiYlv neVn871BRR1vbGVQG7b/bCRxRuxIyEFIGsqfyIITQIZpdLkpekblhjISMRiFq+dlND5GTjsh TuNqUADa6471JBRkf/hpBae3mzq9sOhohMJChv/QGX66SFja7ycRNaV7kSLxN9pHJiwQQzU1 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMd4qWn0k5K3VcUJuWwleh81WioRUWWxC HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2MTRPIt4wOuBJ1+U3aB Xt8WZzxZUv28Yw9kFKLqx41iNfHPBwWy2LJXozcxB+6y7eYb3P9Ye5bbQPfNbxjtPzf+1+9H zNj2yyikUs3bQEDSnOPrd57wa4icBDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x VnkAhUw4AOm3RXvcFzaAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo w4tJpvQX6wTGmiWk9nfBLGkxLFfmN2QrVrmF0KYjPIXJvaMmyShFgfYQzbS
- Ironport-hdrordr: A9a23:XuoJnazq7VB1nUORQ7P1KrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote:
> The 'xenfb' parameter for the '-vga' command line option is currently
> always enabled unconditionally (since the xenfb is not a proper QOM
> device that could be tested via its class name). That means it also
> shows up if Xen is not enabled at all, e.g. like this:
>
> $ ./qemu-system-sparc -vga help
> none no graphic card
> xenfb Xen paravirtualized framebuffer
> tcx TCX framebuffer (default)
> cg3 CG3 framebuffer
>
> Let's avoid this situation by fencing the parameter with the
> CONFIG_XEN_BACKEND switch.
>
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
