[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] linker/lld: do not generate quoted section names


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 29 Apr 2022 11:42:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3n3bJocTB8QXinYCxVTEgtjyEaluQ1aFfAmH4tH+ccs=; b=RIqB2kpXWrjty6YinNW3y2/rfUIwku64N5ojZPJJEAyUxnKZIsd/xSOXIuP47IGDuR+almvB5IgGzLXpgYOsxZqTfq5+c+jnvLv9JVBJ6GMdQ5FofFREY7MBatbslf2auRWxrzkfpkHNHTZWFP0TBev3q/2Q1VVtN3YvmtjV5fOcYzJuSqy2Bo2rmEpAUfL5B8C7EwvQGH5LCVWeFDWuRFklQvZko7BGNt9MYwKSI01P9AnvdcOzXT/h1+Y9vbMKKTRIyImnWTWnth5hSVH4HRqzr+4QcbN7s502Nvct//YJp00KSVX6uBpSKDJpJyDuJkppvm93ejMEhWxgHd4u0Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpRNnSK5Tx0uO60ynl1/3iXhbsigd0F8ySZFlmaqQcLOZSKAVtH09dqenLhQ0KKaTLKiihBdWoZ4Tu8JJ9+eQJJG4/TiNXM6/YBiJFWtsSMAoRfJb0v/VvIPgYNCBiN62eNrnG/OdT0Mti0BfWteGrr+HdIjYlmxl1+EHIUEBQJ/EZDNfobhWGuxXWyj0zhaUJDX/4ohZB0isoe5r9CAJE1dJo1LmRBe0rxRnRHtPA82bjhQPziLupUBPWyP2kg4fXGLr7WGRj5g+QsDbVuHAM2yb4mwbI5xJ6bPJQHgu4IWw6SiQFiBcRooBx6rdBEA3xgJ9LZCTQZVqzGQhNPF9w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 29 Apr 2022 09:42:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29.04.2022 11:36, Roger Pau Monne wrote:
> LLVM LD doesn't strip the quotes from the section names, and so the
> resulting binary ends up with section names like:
> 
>   [ 1] ".text"           PROGBITS         ffff82d040200000  00008000
>        000000000018cbc1  0000000000000000  AX       0     0     4096
> 
> This confuses some tools (like gdb) and prevents proper parsing of the
> binary.
> 
> The issue has already been reported and is being fixed in LLD.  In
> order to workaround this issue and keep the GNU ld support define
> different DECL_SECTION macros depending on the used ld
> implementation.
> 
> Drop the quotes from the definitions of the debug sections in
> DECL_DEBUG{2}, as those quotes are not required for GNU ld either.
> 
> Fixes: 6254920587c3 ('x86: quote section names when defining them in linker 
> script')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.