[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Fri, 29 Apr 2022 19:12:19 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lz98BJlElMHq36e9Hz8KKUh019n0TcAOzbEM6bFURX8=; b=RmXt58etNZcpQyQYnbr9X/qTx2vvBYV33ee7vrDed4ktaEY4neLl0nD8MKv97/0yaAKUQ9uBicHLVqKR7Oe3ADmIgf2PmgUcdOKHC4D1XnNUosC/p8A08wqlhw4XH8jFhZhbGDXP/NGMSquYp5ShGam8yC8ugdNLDCHLAuJ7QvsAbkvXyV9kIgt9ligBwXIgBVyUAaCucqUM2WNK8hJtMxoICHlSHgdCVlNHUMxds78TwuNc0jrLyoqfa2KZ24lQ86/OPJElrFQN/jpOhZIJdnVwKqPry2uyCyJwcSZA0QvcZ3N9DG27cX9pt4RyUIPSUKeus9NxpoFzRgx8EygIGQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJPlUdTVNd+w9JuSiacPs8W06oKuGD5vvxr207QIpztF9/bIx1sPtv1vfba+hFoQHHGQneKR59o72H5qoLsMpfdj1ywROjQYnUJJSOGOHBocfPDwpW9RqWtfbTC8uwOzB2CwIY/T5S+hx9X8cFWWAyTQu6kOiOfJ1ktqAMqmFwW1xr/GD9fm2Wo8M0GFn7QpcfoXf7gF1twQHBQmbxeS+OCh0Yo64/O4TjezxFZO/f3eQphpY7xdxM02leF85lq7naS+q4vMo5uxlTnffGZEeTyFiJgZxmIHh1HEXXxmEsPgaGcjkWTXrWY6/wBz8w0yKuT02WeZsKpZ9OXS0j3xGA==
  • Cc: Christoph Hellwig <hch@xxxxxx>, jgross@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Rahul Singh <Rahul.Singh@xxxxxxx>
  • Delivery-date: Fri, 29 Apr 2022 23:12:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 4/28/22 6:49 PM, Stefano Stabellini wrote:
On Thu, 28 Apr 2022, Boris Ostrovsky wrote:
On 4/28/22 5:49 PM, Stefano Stabellini wrote:
On Thu, 28 Apr 2022, Christoph Hellwig wrote:
On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote:
Reported-by: Rahul Singh <Rahul.Singh@xxxxxxx>
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Do you want to take this through the Xen tree or should I pick it up?
Either way I'd love to see some testing on x86 as well.
I agree on the x86 testing. Juergen, Boris?

I'd say to take this patch via the Xen tree but Juergen has just sent a
Xen pull request to Linux last Saturday. Juergen do you plan to send
another one? Do you have something else lined up? If not, it might be
better to let Christoph pick it up.

We don't have anything pending.


I can test it but at best tomorrow so not sure we can get this into rc5. Do
you consider this an urgent fix or can we wait until 5.19? Because it's a bit
too much IMO for rc6.
On one hand, Linux doesn't boot on a platform without this fix. On the
other hand, I totally see that this patch could introduce regressions on
x86 so I think it is fair that we are careful with it.

 From my point of view, it might be better to wait for 5.19 and mark it
as backport.


No problems uncovered during testing.


-boris




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.