[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Mon, 2 May 2022 21:50:42 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQW2wD7NFcfGazO8HUUSdyAhxwbex56NYFqrnyb5eJo=; b=DVMdVZhLdDzWfe8JaBGkINQapZWNL9CGiE6T0bqy7QW06/tPtY6ZIqjaIaGFoL/9q1xdFWyDQSTJ913VGO8713JQ+Aw96+683df0lYUH9JqPELunm51C18jR8HsjweYXXAZd5jur65v65qfnGreR/tyZhKWKiqnB/K3ItW1qZdsdfGsPolw7jBvSkc/izmaz4CPj2rtc7vKp9HgAUC0v0szoiPytd8/uPBDTdBD9utdL8BCKu5bamNV918Hnh9nMt9k9/lwJS8gSZM3Jcta4M6OaB11FhIZZ611KsYaV8wkx5ST9eV7ocMQPD5hcywPCVWuFGuGmUcxVPEvOB9lqAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FO+xsOcRFQ64WWNoy6SPgol4/CEtu0WNqnUA1sWLUdUV62eDFy1PgTMDr+/wRYoQkqjOzHi6TSk2PyNuNgLQbNETe7jLbsEN1jr9ME8fr2X0NS+JreMoMtJyx6/d/4gkZQWE3ESvy7Mox/fGscJDiorSWMvBVLEuUNsIYUEk/26mj1JMR5Md6yhy5YoCJds/2zwnqRsTb+h4h8Li/LiMh7UutGNGMh63lLd+x6CK8ZJSsr+oBYYa18nvXRXqHw7xflKhHWrpnv7gjdppY1wZXTbjs2NuwRYG8POddx2aSfA4nKQlpUW7GUl/0zlXpGrGkMVd2YzdFyRxIP7HixbZbA==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Luca Miccio <lucmiccio@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, jgross@xxxxxxxx
- Delivery-date: Tue, 03 May 2022 01:51:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/2/22 8:36 PM, Stefano Stabellini wrote:
I gave it a try and there is a problem with unbinding the IRQ here. If I
do that, later when xb_init_comms calls bind_evtchn_to_irqhandler, the
event channel doesn't fire anymore. I did some testing and debugging and
as far as I can tell the issue is that if we call unbind_from_irqhandler
here, we end up calling xen_evtchn_close. Then, when xb_init_comms calls
bind_evtchn_to_irqhandler on the same evtchn, it is not enough to
receive event notifications anymore because from Xen POV the evtchn is
"closed".
Ah, yes. That's unfortunate.
If I comment out xen_evtchn_close() in __unbind_from_irq, then yes, I
can call unbind_from_irqhandler here instead of free_irq and everything
works.
My suggestion is to keep the call to free_irq here (not
unbind_from_irqhandler) and improve the in-code comment.
OK.
You could add an argument to unbind_from_irq() to keep the event channel open
(I in fact am not sure it should be closing the channel since bind routines
don't open it) but that looks pretty ugly too.
-boris
|
