[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 3 May 2022 09:43:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=XvvE7D70i/wOo1uQSQ64vOYkPv3S4nV1gQRa+sE0hatAj0bNMHFiOKwBfV6Sv6oiTkH/mYXIMLEFd6660WqDsQqTu1OOdBWjJLVQmZhSV/1/CX3zPNd3zXmorx/4jKC0vMrl+3qRXdL/lI6OPbB4TEk1zC1cmHXq60VnKXPZMYyRgY9YIdgIlpYGdnfONT9BDnkyPTQL0IkcuP7wVPOgswtm62a/0zsWVSfgrtNCRRS9hN/k28dujcb5Ubl0FsIeKxnMp0rq56ChaOJMjRjTDlKWjKEshf0hRxxYNAj1e5XKqLTKRUnTNBwIKZnzp7AO05tH+pL3HvBUi5EMAAWIcw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=YsXyo13sHtcwsR2QsyEVtPve4E5/ivAcvPtQw5myr0ICzG7VAedRK0MhVjAWj0iLiD4x6o03tz26O9rPe0Wh/rmnuqF8cinlA/kHeQ9J9hWnSGJFJdcPZ3kNxPiufeDWdouWUmxtzHSHzeTrpg32Mz3b/1vt21cI9h8Xn+dE9e4J6ZfF3XNF7hAGziloaNlbL/d64bwLi+mzwaQLYXjIciQfG4BWZpzh3Lv1SqJvRNsAdKQ08Y08DYVpWAEvXttfE8Th6d+I6zEBYhfQTeEK/HkToeQWtOoOnEkJ//B8mPJ+/UHOiYnWSgwcja84Driu3kHKJZUrS61rrEYxwX3rIw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nggAKUkkq/JO5/BRWLwQiFus3nSsBz2+QtjAZW3weO4Aa2bpepSn9dOUNOVFvvSeBSmWzVKzJmx63xhmz0ukf6/okd924kyfw56BCHAVXDuxJKHt+lMhF5D3Vfjn1zcouSq9cof+s5fflnVPH6lupt/wlSRB1zU60ANpbO58aVDVND5RZLEFJuea3AZSK1CN0dLB7ASVoZ+rGsU5EwPnmqBZ6mf62fgfZt37mpWvh9Jhd/ZBq7LCk8St3xhoS6o84WoT05JyeRClu4CIhjHF2FC4oPoHAYgN5coifl9qRMfnSYtqCFLLyJpIBXbx2ggLJ2F8eE7KNN04wtdPYW7kew==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHTzNU+sr9mLOTsqGIXNc/I6doycfgXT5CyMnjxL5+LA0FTQ56DcFfiUHC7gvWqqQT8QCdyJkexKoG3Rt7zTGi34N8DxPyG7z56dob3czOXLsZSScKSMzFh+bA4Hs/cvM7ExveJTICB+mtRMCU5yzQ0XrFiVA9oJzSP/3mX9YQlI7Sx1tCTPLytqaaWdI2RjS513Uu575zG175xM3UDzS4HPO5UqYj/1B77dy+iWekVSCvh32UFHruN96xUmTWcISnchIE7IjLGVr8MIshHHt2kQ5XVgwWHjtmr2tnXzmY11xWQ9ChJNtJbboTlosSiC2xxRgF5dzqqQIhvLKYlnYA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Scott Davis <scott.davis@xxxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Tue, 03 May 2022 09:44:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYXijv9StER8938kifKUVqRlYIt60LmLoAgAABtwCAAAEnAIABTJWA
- Thread-topic: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup
> On 2 May 2022, at 14:53, Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On 5/2/22 09:49, Daniel P. Smith wrote:
>> On 5/2/22 09:42, Jason Andryuk wrote:
>>> On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith
>>> <dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>>> index d5d0792ed4..b9057222d6 100644
>>>> --- a/xen/arch/arm/setup.c
>>>> +++ b/xen/arch/arm/setup.c
>>>> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long
>>>> boot_phys_offset,
>>>> /* Hide UART from DOM0 if we're using it */
>>>> serial_endboot();
>>>>
>>>> + if ( (rc = xsm_set_system_active()) != 0 )
>>>> + panic("xsm(err=%d): "
>>>> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n",
>>>> err);
>>>
>>> You want to print rc in this message.
>>
>> Thanks, but now I want to figure out how that compile
>
> Ah, arm which I do not have a build env to do build tests.
I’ve built this patch on arm (changing err to rc), everything looks fine, so
with that
addressed:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> v/r,
> dps
>
>
|
