[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 3 May 2022 10:15:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=b/h4ZinUzCs+1d5DGbch1bda5I6pvlnyfh2IAK9HMExXIIWuvgMxYQFB9rBpRo2YU869VcPpTb2lcjIS7bztwc5x9ftYiG9/ICgmkjUEXWV/zzsiYzxckJ8OEtfeilClqOgFxS66XE39v56qlhh9g8GLXN/r1inntzygvrGr7aWyqRsCNCNZhGk/qe9Hu3cE/j0uYPD6iaeDT2CIll34Ba/Y2UUlaIM9z4hvdx916udaqEnpE1QDO3Utjk7VzzN/8sc2c7aA7GgnijaACE/CwlgrvKklTon1VhNenOBy6vNA0Cp/fVbCG/ZAcS+H3sc0Nr2TJQWwwuj7CoVKpSFK7Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=YCg7h3mmhtkKqVUN6jRPxFoQvT+7/ozw5rK362QPhBqmOgG3bGwOXQp61ivEi2Dm3iThRVaQ6RyH4EP5HWtltNnZA2twaRK9WCgZZgwlsoLwePfbPgwiPbtRtsVyyDhsaPV9cd/1buawo8JMlk15zYHN65YKvoBQeblamnTmTT77DhsH72FPrFbPrm86vKDtfTmBlYdOJUTBqk43lNpK6Y9qt1KIxm/H3/ptl8fKwmGIdaU0hIfkfZ8tzw+IwYRmHCjggblfcY1rRdgrpcit/vkowgsVKbVETWM28+JcyWzub2zZiyoN2umVtQvzpOMtY7gBoY6T3In8TKTvUVNF8w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nySQ4NXdCoBvf8kOKPzmIgO2nMb5Bm2JZBVm+LJjWrUBDg5w5rAvcQkTCLEyRNB2RfxnelSksmrm0zKMwiMPjhyjWFGJ8AQoUnW1xYXULk9VRWzaGpuv0pucJy6sbo6/XuOjC3fJZ1X8iKMrGZ4r+2xaHG2+/b2eznnTOh+855cLicrHWHuanz08DBgjYPOMuHBWslA3zsrGg89EyqFjaly3BSQWLqxn8zvSPiInT878cmeV0UcxaTr7+2QQXZEZElvQbtWjanhxXBzyg9jmC3YB/f2frMjuKmUfclNhuIT8P99uIbmDmdlfPoGXWNKdzQm/In/Waq40B6AE3muBzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CS/thZwDOq80pyz1v9lTUHoNlwIG8WL9kDRXvD7mtUlrgFa5DUXkRJ2g4yGPc8iDyydQWUgg3SqqD2rTYUI9ZMnnitRhktNZwzHckN359yIFb+hghu16CVrc5ncZwNYXMgRTQpwKB74mJiUZW3sM0w2O+idkCRERNJUlFZhTScTaPKZkQfG5bKQBbccjKlevKbfaHrsHQaDmLQyGNXELW6uWrioY0a/wkC3ULmnn+rmEsUnSEcuhTDmc1hHWb0vfdHvKJid0rNSFnFy3bzjAt23gRIbyUjHMaT8dQNqkNQT9PClrVhztAFBk+C8LniMvAYDwYmWbo0oL2wM/P1qdUw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Delivery-date: Tue, 03 May 2022 10:15:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYXAvNeYUSSCJ/SEOm+/N9Ov4Ija0M9TaA
- Thread-topic: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length
> On 29 Apr 2022, at 21:57, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>
> When the length of the string is zero of_property_read_string should
> return -ENODATA according to the description of the function.
>
> However, of_property_read_string doesn't check prop->length. If
> prop->length is zero, return -ENODATA.
>
> Without this patch the following command in u-boot:
>
> fdt set /chosen/node property-name
>
> results in of_property_read_string returning -EILSEQ when attempting to
> read property-name. With this patch, it returns -ENODATA as expected.
>
> This commit is a backport of:
> https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@xxxxxxxxxx/
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes in v5:
> - backport from Linux, I don't have the commit id yet so I used an LKML
> link instead for now
|
