[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 3 May 2022 13:17:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=GiHK5k9ADypji67am1zxyOhCjeYN/KHVO6tjBUu5pkgCdc28qOXQ3SaLGEwdCtQyD4DvZjtYyPorh8Jzap/5ZiENrfN13qcUWmYkbbfocxc4ckt809YKTjBpEgRuiva/UVVRn2YTE0shuRDkjbYYErWqWnH1A/nWmsDnC0guLQIsmi0rjwiq4AFtgXgDpVI8eDfH3H6ZwJff5ifNILMLpFL39gJ1KXC6sYmrzlW9QcU22G13x120McZruQMGgNL0uF1M1Rr4y2DrJCT57XvO7htisd52jCf7ooQitL6+9FBWRdw39aNsB+lU3zKsD2j35aUKWae/duFiaqXUHOgOJw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=Z8DUTJos6sCXMeUYe0YeiFpW89D3jaxGGBmYYVUgDJfeSVjZ9wJdjbo7Dl5kqHJsLcs/+NQToVzzWn0RrCG7xEWoT6wZyqyjo7VQ7na5P9koIuihFrEqduu1SxuW891PTAchObZzExcf4JYbf6mNgQ9fAwdcz0fOcDLA1NhtvOyJ/h6gtCP95JqbaEOc9msH/Yzs93HsHa1EPdmrRmXUIbKOBAyXmuU5JsnF+v0OH4EtWaCg77rD5crsW4pu/JT4WIET7rKZQpK4ahUvkRbdJlE13Wr8DSv8y4xBezjKH40fpJ+Ik1xhhdJKutZz1bJJ+gzsEMLdW6JR/aSlhVNtBg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FuobrphrFplM4uZya157kmdf9BRwf1xOWWw+BPbIugLEHncsCHNBEfL35W+DmN50bfpMFS1KUCdoPx2Pt+t+b5KsTI1w+USBqp+KSsY01K9WdpwNGqBkbCsmg7Z0s6Eu04zMminHOhVYW52ofLVHCTOeJI7t6UCsYB6HCL0R7jet7CahmS/xTgolg7Sajux1U21bMwLGmWJw202n1c+hZzWS+17c//8/GSa7ykC51ego+CRNWkC7Sv1PHQaxF2yyGWC6XBwqXWPry8GHf0I21bn+41o1PHlxG6Cmm3dEeu32yu3LV6k8jLjRpfc+Jqx+05MEdVv95Id5SA89MoZKKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJzzc0IlJ1pAm53MVorNpr9TpkUSaFBCOPb20cJ1a6i5B1ZqB6Paw8O7Cp/IO0mvnJiYLHC+LMvg3K3/OLr+5GT3qilm6helQIM3rE7Zc6tKFqW2xEwwTAiuG6xSay9r0mg8mO2zSoe/G4ZPKKdVrDUxOxNUHyqNKkMWvF0XR3AOi2qbqhuUAatLKZbOQgRiOsM8OlhE3IixCAESZDNr4Y6b0etJYYCmGB3exjr6GcuFGYDFaIzAjVcyBW+TAmejMHOPoTEZ5lBe44CjrJxKc95PMRT46U89QtBF+e3npJg1fVZAv7ezMduLlHsfEuQeYcS1FCQTQKR4KUa3CilAJA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Scott Davis <scott.davis@xxxxxxxxxx>, "jandryuk@xxxxxxxxx" <jandryuk@xxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Tue, 03 May 2022 13:18:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYXt+O5KwXx13Nl0CUGYEFbsIOk60NIqSA
- Thread-topic: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup
Hi Daniel,
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 0bf63ffa84..b93101191e 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct
> domain *d)
> return 0;
> }
>
> +static int cf_check flask_set_system_active(void)
> +{
> + struct domain *d = current->domain;
> +
> + ASSERT(d->is_privileged);
> +
> + if ( d->domain_id != DOMID_IDLE )
> + {
> + printk("xsm_set_system_active should only be called by idle
> domain\n");
Sorry I spotted that now, here in the printk probably you mean
“flask_set_system_active”
instead of “xsm_set_system_active”, you can keep my R-by after this change.
Cheers,
Luca
|
