[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain



On Thu, 5 May 2022, Michal Orzel wrote:
> On 05.05.2022 14:29, Juergen Gross wrote:
> >>> -        /* Avoid truncation on 32-bit. */
> >>> +        if (v == ~0ULL) {
> >> No need for brackets for a single instruction.
> > 
> > The coding style says otherwise:
> > 
> >   This does not apply if only one branch of a conditional statement is a 
> > single
> >   statement; in the latter case use braces in both branches:
> > 
> >   .. code-block:: c
> > 
> >         if (condition) {
> >                 do_this();
> >                 do_that();
> >         } else {
> >                 otherwise();
> >         }
> > 
> > 
> Good to know. So Luca, you can omit this comment.

Thanks Michal, I addressed the other two comments.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.