[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
- To: Jan Beulich <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Fri, 6 May 2022 07:41:45 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=fxwVZyw1q6wLtDMIvz68lmVsw6U2dBmIljQatK/pLTJjkRIDNOgF47Zvu52h0c4CPs6l3z+5oEIsR4YiPYgplTnNd4zxSmo5SIzr4ZXes+nG9TdHqkPzevt2dW2uJ2QsOtpmzPSErouMx8eI6RyODaJzQ+LfAlingsBjbVu+YGxO3tKXiTQnH0p5M32p0GalpLNEv2otAaZDPEi/1iJYschCLQJFjJk6lTO3FKeNpXY959RqsaXpBOJbl1eBAXfABYorxkxRxzx4zijgx9lei/yxHg7txZQx4y4+ayk6OoFe06KazHC7F8HxVoHTlcOkvewalxFKiDTy7EOJra379g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=QW+azcNbZ9mrFNoYOp1gsyAxYpE4GsPb3B6QJrngkbspKY4J7yYeElpph9mAL2x8WrKplA+K7zG5dUdw8MS7b06pWlQuM6PRxTb4UJjlrw607C7WmF6+TddIefCTOKkHemhRYeFbOrHMvg5sUm2UaxDC5wPBRJgRVenocWC1z9CHQ/p/fZtYxSSNidCQLLqax5HOIT4qb8MlRbvMbt2vry7Po+urInZ6FGZj6Ho4PVprhxZTDYzAY2v50yvTZ/8MabVnq+ygqkTkvUkvBToEPa8E/opWrQ06u0dx16fluoWWsAm4qZrxr8EkQsVF15zWvxYikKQvaf3QqCkkd7kk+w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YTz7zwhNwAgODmBY1hDe0HjKqhSxEQxOq+sCu/ff3LjIaz3z4mU1fVao9tCRB8vTDCReO4x17lXoeUrp3CoZIatanTwhdpC83iDiaTZiiSC3LgwtJgvkiwr5REKjcazsXIhIMjmB24AbJQ1SsPWleRqcaEvfZswWKGhRSSaeIEwSbO0TOkI/y2NEqj2YT50jUA4MZswfdgBLl+585HTe6a7h2ys2YVr0xusdVxYxd70CM9QicBr4Ahgzb+yVLThRsIDRox7vFxLuOdyrSZn4/1jOfRzw7+VmcRkW6+QLknG54dM55vFb7yi59jWCTa0pvSWc3JyphA5hmBYqgg+gkA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqWKfLO4cMCtHEscYi5KcqCV3VzrAJ+WXSfMJd+Tq3BIsuDGfIII/NxZYmTerFLEoAaDhWHYrLX9+2oCUsZnRLjVD813W4UAU17UNitfYB0wU91JQ2xqaTDqT/1qFha820GpM+KM6JDFY2lWE0+kdBCI+N9ua8+yEBDe7Gvr1/oYaOTLlgttIWn1y86H7uFk4ukWDPFJZliGKDx9P/thPgC+73Bn8R/exyvSbVo1DovITbuAp6n4jw2w6D+LtFhQI1sSrAyrERoig3i+QWhzkaJ8aFhnH8qwAqeYJihufuFzvmWrtyLfe/Fqdpl9GCsghnsICZZF3UUgnQPc95vBpQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 May 2022 07:42:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUIAAL5+AgAAR4BCAABRbgIAA0kVwgAA3dYCAABUWYA==
- Thread-topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
Hi jan and julien
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Friday, May 6, 2022 2:14 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Henry Wang <Henry.Wang@xxxxxxx>;
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
>
> On 06.05.2022 04:59, Penny Zheng wrote:
> > Hi jan
> >
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: Thursday, May 5, 2022 10:23 PM
> >> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> >> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Henry Wang
> <Henry.Wang@xxxxxxx>;
> >> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> >> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> >> Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> >> devel@xxxxxxxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on
> >> populate_physmap
> >>
> >> On 05.05.2022 15:44, Penny Zheng wrote:
> >>> I misunderstand what you suggested here, I thought you were
> >>> suggesting a way of stub function which could bring some optimization.
> >>> The reason I introduced free_staticmem_pages and
> >>> acquire_reserved_page here is that we now used them in common code,
> >>> and if they are not defined(using stub) on !CONFIG_STATIC_MEMORY, we
> >>> will have " hidden
> >> symbol `xxx' isn't defined " compilation error.
> >>
> >> This is what I've asked for clarification about: If such errors
> >> surface, I'd like to understand why the respective call sites aren't
> >> DCE-ed by
> the compiler.
> >>
> >
> > Because both definition of PGC_reserved and
> > is_domain_using_static_memory are not guarded by
> CONFIG_STATIC_MEMORY in the first place in arm-specific file.
>
> So perhaps that's what wants changing (at least for PGC_reserved)?
>
Hmmm, I remembered that when I firstly introduced PGC_reserved through
"Domain on static allocation", Julien commented that he may like it to be
used for other purpose, not only static memory. And one example is reserved
memory when Live
Updating.(https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxxxxxxxxx/msg97829.html
)
> Jan
|
