[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] x86/shadow: Don't use signed bitfield in sh_emulate_ctxt
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 9 May 2022 15:19:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x3J9GGBre8qxJQVjdYz1Xg5oJYU2Mu3jLazozNoGKLI=; b=NRibSyhyljOjz4EHLgP9tNjQ1DeNRvMk66pzs4Ov9ioOCCI4DWGUmYqrYLatV3Z+oX1C1q16jFdx2stSw8CLblfLgCxij2UK9J/kZKWi1FvVqQQwrR7lwUem0RRfVL96fAu59F3h6IthG9o4SDUTTUNh8Mlf5sg9zHLtcGGxrKajC3zPxYucqToEwOlIsZ/DB2CEZf7i3GNlpqyEbiDwJDE7jckiDeOW/oyB7vVz6WlPL5CVMCbyga7qcZTE7qo9Vjd3H9INY8hrS2I4JGa4rzdnRBkm5hbI77euDg0GukO4g4xIbNaxRa3rmCcvaeVRRADC/I3b/f3yszGvrlFRvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8tKRAU6NzclfOOrRYBcCChAHOkF8cHOvDwTUBcFweaF9ZBD+8KiTkLGB9z9GCJNlfV7HcYTO2tAmRrCI1JFxQfdLT3J4OgBGj9evJeGsRrpGiiJtjoiqkirvfDMia7+oBetaxYfUl1lOmaq+NzzrEnujs0zkURMrCwbY9GifX3QOyFZ6lBtGTGub8srOxZosZ5FohC0fqFnYU6c09uFQfNTqL3aYo0IawcKVSbH+y3PbVOJT9CFqG1c0tHEfIz1hXjGcs48eSvmhyyZE+4sQXB1NzYwYF1m2cJUpxFOBBQnLDeshANk7+LiXpHzSZG7hS9AOWdv8rSZLFKKiZU+uA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Mon, 09 May 2022 13:19:50 +0000
- Ironport-data: A9a23:4ayOBaAUBuSpkRVW/+Liw5YqxClBgxIJ4kV8jS/XYbTApDwl12cAy TZODDyHaazfY2Wkf4oia9yz8kkDvZPVn9NnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhR0 YRB7cfoTTsLP/fCybtCfiAFGBNHaPguFL/veRBTsOS15mieKT7G5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t/B8yaK0nJzYYwMDMYnMdBEOyYf 8MEQTFucA7Bc1tEPVJ/5JcWw7/32yauImQwRFS95rJ08yvzyxxN7bnkNtmSQ+zWfJRxpxPNz o7B1yGjav0AD/SPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fXmRrOS9i0W+c8lCM EFS8S0rxYAt8GS7Q9+7WAe3yFafpQIVUddUF+w86SmOx7DS7gLfAXILJhZDddgnuckeVTEsk FiTkLvBOztrt7GETGOHwZ2dpziyJCs9IHcLYGkPSg5ty9Puup0phxTDCNNqCreoj8bdECv1h TuNqUADa647iMcK0+Cx+wnBijf0+ZzRFFZpv0PQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytbFUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:jeDaq6h05L0udvigLsJ+m+tpZnBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, May 09, 2022 at 01:24:08PM +0100, Andrew Cooper wrote:
> 'int' bitfields in particular have implementation defined behaviour under gcc
> and can change signed-ness with -funsigned-bitfields.
>
> There is no need for low_bit_was_clear to be a bitfield in the first place; it
> is only used as a boolean. Doing so even improves the code generation in
> sh_emulate_map_dest() to avoid emitting a merge with structure padding.
>
> Spotted by Eclair MISRA scanner.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
|
