[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/p2m.h: Add include guards
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 9 May 2022 13:23:45 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iL73GEIo0RvvqQPfebHpzrj1wMJsKL8iY3j3lm8kTBo=; b=HzMreJDAqMVKCMQzn/y/NAXlpyRXBZr2ciJslU5H/HDeiQBz7pHUbgxdudo3DoldvBeYyIQ8V902o/X1B7jIBDWhB3D4K0c8N/oHr0p3jHjTkWIF6MBCAj+osusX6A0RELAo0PfMx1DCH4t3401Xn6NGKDs3HdJ3gdxiBBctkYwn0Lj1Z6s/sBEJ9crT0FUVmucbs/xoll0fS5cChxl97U+qXtuirsC96OsS+zGS+Su0k0H1ta4l5+7SFh5m5E4ztruSMm1hU0D/WRsajTr61jwDpA4HpZ/X5OB4lfIhZdEj+qtuGk3nJFzrAJElMhfnJSm6HBOAeDxe2xWXC104sA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRKdd4Zys4RJ2XK110MrzUEeAP4aHRTcA4hpMVfcQCaCnLS9rZbAUIl/fsR4e7/dmHtbB6OQ9g+/tk+eOX4fLyCK4YhrGfBbxL3jMJ71cpHp+Q8Sn+/hv55DkD05bO69I3LD7MPtsovekUPzqWBbMXeIF2Xe8OFWwd/oOfAoODsiYGVF7zaTKXYc2vnfNY8sipok8+BV3BZ921nrQ53UfDaN/CN8+WtwrpkEf9fmJg7lbzaQoEHpgwUIDQ20cTG/qZtdOzNRsgpLv5ahaWXf3KHnFRsOOPnIqSZlf8q7am3hyzSvO3i+9sB5g48DTJ0pise/jX0OY0shRDez0C884A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Mon, 09 May 2022 13:23:53 +0000
- Ironport-data: A9a23:kn/Mua8JzvxLZIZkAs/oDrUDUX+TJUtcMsCJ2f8bNWPcYEJGY0x3n WoZDGGEMqmMa2CgKo1+Yd7np0wD65ODxtcxSAVtpXs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IDoW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbWsVQsEI6znotoMbyZ3AS9bPIAewYaSdBBTseTLp6HHW13F5qw3SWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIEItNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK/ftvujaKl2Sd1pDfYN/YWoTbb/5ZvUiIr 2LKwmHJLC4VYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3C WYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ l2Um9LkAxR/vbvTTmiSnp+qqje1NTkQPHU1TyYORgsY4PHuuIg2yBnIS75LGqOvksf8Hz22x jmQtTU/nJ0al8tN3KK+lW0rmBqpr5nNCwQztgPeWzv86hsjPdD1IYu19VLc8PBMap6DSUWMt 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz3k5J/Vei8OA1DGXo=
- Ironport-hdrordr: A9a23:JBOHlqDnggfoqEvlHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDTa5rPw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYY5/ES9ABGv/aoE600JAs5fhuma0Why+AgAABlYA=
- Thread-topic: [PATCH 1/3] x86/p2m.h: Add include guards
On 09/05/2022 14:18, Roger Pau Monné wrote:
> On Mon, May 09, 2022 at 01:24:07PM +0100, Andrew Cooper wrote:
>> Spotted by Eclair MISRA scanner.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Julien Grall <julien@xxxxxxx>
>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
>> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> xen/arch/x86/mm/p2m.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h
>> index cc0f6766e4df..dc706b8e4799 100644
>> --- a/xen/arch/x86/mm/p2m.h
>> +++ b/xen/arch/x86/mm/p2m.h
>> @@ -15,6 +15,9 @@
>> * along with this program; If not, see <http://www.gnu.org/licenses/>.
>> */
>>
>> +#ifndef __ARCH_MM_P2M_H__
>> +#define __ARCH_MM_P2M_H__
> Do we have any guidelines regarding guard naming? Some files seem to
> use __ASM_X86_, others just __ASM and some just _X86.
Not really. This one is especially complicated because x86 has two of them.
$ git ls-files | grep /p2m\.h
arch/arm/include/asm/p2m.h
arch/x86/include/asm/p2m.h
arch/x86/mm/p2m.h
~Andrew
|
