[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/6] arm64/find_next_bit: Remove ext2_swab()



Hi,

On 10/05/2022 11:15, Lin Liu wrote:
ext2 has nothing to do with this logic.

This code was a verbatim copy from Linux. Looking at the history, I am not sure there was even a connection with the ext2 filesystem (I guess this is what you mean?).

So I would drop this and simply say that we could use the new helpers.

 Clean up the code with
xen/byteswap.h which now has an unsigned long helper.

No functional change.

Signed-off-by: Lin Liu <lin.liu@xxxxxxxxxx>

Other that what I wrote above:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.