[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 10 May 2022 15:27:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=TwZkf4wa1PVAjFL5NHfG6YDgHrE5UrfE24TwIr+yWSsiLW3wNB7dqLvKRTPjkDWR+g+HRPJDoaeeEF9dYSH0AM4GTIh2MYLemLjA8MFmX/6NN8calNXRuMQAzP6iIU8G13N1LYtTqoYK/0sIkzLd7816+YtvF6Nwv60PAMtgKr+082XCa2yeuwqwSUfSXznwTiICMTiw4ZCCRKpNX5D1uhAy3iAHndT9Xk0GZ4rS+0o1HT1HGD0k1XEpeK/2XAEokgpgAJwrMrsGMe2sB/9ap7r+0d3ZfXnogotpoJbbpZlCAANr7dUQKqjXbeKwRmU0JeOoeJRe5UdIX81jiAAUpg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=K1zUr0idyEVFnfV09peZRvewMjPwWimIfnKOmW9CidYn5FwVkwVghCEwe32GAdCBTGMdpj2u2r6srf8FYKkgVnV0peQb3/Xoz+W7W1GIv1dTyy8AqztL0cGqG3IrGEMPARXsKS7uA99TnhfzYoTU9PYi5ARm8oiY439oNaDQ9qQLtYC5IJovnL8kgV/CFhCkpn9hAXRkIfvmBr+4V46U4Pifqv/t3oHKwtn5SWwchAlfzcKSaGIRdqM/os5d0A/aINdDcr9J2QwgkPStHFj6TLoVPoZ3suFJ6eOpms3vHoVO+AK4o6za2dqAAyQm9srnxZbMbzGpodauaCZo7qcUgg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=c68OmMRCPPjmMiVzX9UexYsFC6mzDDSPz6C5kGHkCJrEJmNoWh6f2rGgZQkqHN3js70hQFTkfcgz02Z/27nH1xs8Zr2twesmUjnPS21eRyRw550FWKtP+WtJOBAeZFfIgZ2xvNVXI/LCjxAYFE08lTXFu/Av9WN9bUqVV93nJ3ZmqMPxK4RQ4IuL/LV2v94kbWR5WrMsntvlcA5mC605VtfEfldHxhK4ZdahMySbuoG5/FaKW5BYuvsFKe6gA3fWiWHWM1oFnUQsmCmYd561wygV++EVCK34QHpDWeWaUvXuloSAClKvnD1B0H20JwEmev+F5dn3d23L8P9XdcCs/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IZ4TSryOp5539bLO9+xVHevMhVxHUhWXuaKQ5MrES93l7VaRrtO/ZZEYDHUOUUepsJOMH65azGo3vdydackwCi+4FNUQcMk10/it6xEX7UG6H6XoKC1aiwUNs+NnlxWM6Ij6RYH5EqTh51diL8a6F7hJ6uFUm3NfvOlbknwr56NafaRzK4qJsf8hqCjxAElF/sy6q/OOqu+vi0orhmQw/slFYjViQQjP7G2kSt8iSLP+lzbLsxhzHXBXFewB8U/lQ9bJhgSE+hDjRfR4sHNcnThw7LOFlCW29mKYb4Uha9d6Lqdef5aBg7ZRyTqWKUdE6s+ty3omvSGbGkiECMdL0A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Delivery-date: Tue, 10 May 2022 15:27:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYYBZZ0f0HhWtpOEKVI6rFIZ2ezK0YRJ+A
- Thread-topic: [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen
Hi Stefano,
> On 5 May 2022, at 01:23, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>
> Sync the xs_wire.h header file in Linux with the one in Xen.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> ---
> include/xen/interface/io/xs_wire.h | 34 +++++++++++++++++++++++++++---
> 1 file changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/include/xen/interface/io/xs_wire.h
> b/include/xen/interface/io/xs_wire.h
> index d40a44f09b16..04dca77abc45 100644
> --- a/include/xen/interface/io/xs_wire.h
> +++ b/include/xen/interface/io/xs_wire.h
> @@ -10,7 +10,8 @@
>
> enum xsd_sockmsg_type
> {
> - XS_DEBUG,
> + XS_CONTROL,
> +#define XS_DEBUG XS_CONTROL
> XS_DIRECTORY,
> XS_READ,
> XS_GET_PERMS,
> @@ -30,8 +31,13 @@ enum xsd_sockmsg_type
> XS_IS_DOMAIN_INTRODUCED,
> XS_RESUME,
> XS_SET_TARGET,
> - XS_RESTRICT,
> - XS_RESET_WATCHES,
> + /* XS_RESTRICT has been removed */
> + XS_RESET_WATCHES = XS_SET_TARGET + 2,
> + XS_DIRECTORY_PART,
> +
> + XS_TYPE_COUNT, /* Number of valid types. */
> +
> + XS_INVALID = 0xffff /* Guaranteed to remain an invalid type */
> };
>
I’ve checked and seems that here there is this missing?
@@ -59,8 +71,10 @@ static struct xsd_errors xsd_errors[]
__attribute__((unused)) = {
XSD_ERROR(EROFS),
XSD_ERROR(EBUSY),
XSD_ERROR(EAGAIN),
- XSD_ERROR(EISCONN)
+ XSD_ERROR(EISCONN),
+ XSD_ERROR(E2BIG)
};
> #define XS_WRITE_NONE "NONE"
> @@ -87,9 +93,31 @@ struct xenstore_domain_interface {
> char rsp[XENSTORE_RING_SIZE]; /* Replies and async watch events. */
> XENSTORE_RING_IDX req_cons, req_prod;
> XENSTORE_RING_IDX rsp_cons, rsp_prod;
> + uint32_t server_features; /* Bitmap of features supported by the server
> */
> + uint32_t connection;
> + uint32_t error;
> };
>
> /* Violating this is very bad. See docs/misc/xenstore.txt. */
> #define XENSTORE_PAYLOAD_MAX 4096
>
> +/* Violating these just gets you an error back */
> +#define XENSTORE_ABS_PATH_MAX 3072
> +#define XENSTORE_REL_PATH_MAX 2048
> +
> +/* The ability to reconnect a ring */
> +#define XENSTORE_SERVER_FEATURE_RECONNECTION 1
> +/* The presence of the "error" field in the ring page */
> +#define XENSTORE_SERVER_FEATURE_ERROR 2
> +
> +/* Valid values for the connection field */
> +#define XENSTORE_CONNECTED 0 /* the steady-state */
> +#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */
> +
> +/* Valid values for the error field */
> +#define XENSTORE_ERROR_NONE 0 /* No error */
> +#define XENSTORE_ERROR_COMM 1 /* Communication problem */
> +#define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */
> +#define XENSTORE_ERROR_PROTO 3 /* Protocol violation (payload too long) */
> +
> #endif /* _XS_WIRE_H */
> --
> 2.25.1
>
>
|
