[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 18/21] VT-d: replace all-contiguous page tables by superpage mappings


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 11 May 2022 13:08:06 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OJWgfGFO8DncUUY05mQZ8PEOgtI+BJ+iBil/u2rwa1w=; b=WHg76gK4JsE/skzPZ86E391T7cNfn7msGiwkXKt+uGSbCPMGUjtGrL8a8CqmCby6+k46rW8xqFYqKCIy3jWE/SIiAKEbDaViACJmmhVhXxtvBEhDivsN4Zy6CUCTEZ7ClcjroR4Yljf9isGJysvb0DU2j8lkXdEiqJkqDmNIGjGAoP1MOjKJuER/59yIjEs2CnoIMvwQzgCCYweNbjfzadoo8acDB7eWlakmrI7sl5pDqryAuB3viUP+o/DiAqcfP1ucjA1Dv898rYb7BbVnLDiIl2SurHBjxhUmSgUHUpcDc2xicVimZJCgZgXCFgpZGzLXCOT3gM+71+AfOmAepw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIaj+cb5PWp2kii8cAb26KHQqPqFY4VsUm2VKeKkKo4xiC6YSszk2JXeukq+xrLTthnOQaq8WWsNhxOZm1lOOpNwBUdqI5Zm5FIveDoBAAho1iufgGCO0ppM1t4B256JYP1lu3oF6Ejm3AvDlAeGKBAnj/Jnl2DtvTFMOnlZj/HQeO7ztKWEHGaiDdcwVBVOpIHqB+KnVep62ng4/E4du9aNGxw+E4+/uF312TBHgGRC6S3/g1P/SJI63VzVYf57ecNw/7G7A/dsuK3dPzo5Cj92CvIK056V3vk2ssCS0OOW5YHiWIa+vtiyAt38SWEB2i4MOWFM/ErRN/UdhdIxqQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
  • Delivery-date: Wed, 11 May 2022 11:08:44 +0000
  • Ironport-data: A9a23:e5Ik4q09Ozx2Xc/ST/bD5d9wkn2cJEfYwER7XKvMYLTBsI5bp2FTz mUcX2jVO66KM2Wnctp+PYiypx5V7ceGnYQ1GwQ4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1vsJaLZCwTb5aUv9xFWSJkOi8lP5dvreqvzXiX6aR/zmXgWl61mbBLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B86dBfmTjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SCjLWcB8Q39SawfvHrt/Ap3y5TWEICOIIe2VNxEwheGq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0c9ldDew8rh2Mw6z84gCFC2xCRTlEAOHKr+czTD0uk 1qWxdXgAGU1tKXPES7EsLCJsTm1JC4Za3cYYjMJRhcE5N+lp5wvihXITZBoF6vdYsDJJAwcC gui9EAW74j/R+ZSiM1XIXivb+qQm6X0
  • Ironport-hdrordr: A9a23:Fcge/qAIvTEYJW7lHeg/sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dNME/N 323Ls2mxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg72w 31CNUWqFhwdL5mUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 25, 2022 at 10:43:45AM +0200, Jan Beulich wrote:
> When a page table ends up with all contiguous entries (including all
> identical attributes), it can be replaced by a superpage entry at the
> next higher level. The page table itself can then be scheduled for
> freeing.
> 
> The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap
> for whenever we (and obviously hardware) start supporting 512G mappings.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Like on the AMD side, I wonder whether you can get away with only
doing a cache flush for the last (highest level) PTE, as the lower
ones won't be reachable anyway, as the page-table is freed.

Then the flush could be done outside of the locked region.

The rest LGTM.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.