[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 11 May 2022 14:41:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=CBEyz1K5GbD+cSBLU04t0mkvK3qSnC6waOiQ7bnywhMlGkNMz02WziTY3P4n/QE6Vb8cLHfOSuWAPU3afGuBt5XmlKTbuVsemyNpE1Nzsp7rd1mh6Pm9MH6KabaCHKKHFEDn+7LEY51cKZQKThXAY4wDO8l4Cpnz+Apwq/3hDtSkWd4Ty6Sw2VL05hY26GaKcZlrE1MUS2XRfUUo0Fm046MUcginZZbnBN7RmMqHVw8On0ZJtqKUB2KWWNSMdJqHa3i1lmqSMyohpOLCvlnRI6aN7xi2SmOtKwfE3SzZi/3aZBfdulrj3iF8ro98IRnoBWkV++zB5KGMnE1jeE8sug==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=bRz8CvWgDIsgCUBILbwygqqvkEzVQ1zVlHeTZTsGREk9HbNxB2u4MwyIiBM9KeE3qA5SQcd3UYRGO7prxR6zoZ1omkIKjtWrHc/9E2w8fM2pV1lnD9BkvR4xjc+4/FO323L1WBO4y7wNhCWc60LgBtvcGxswONQBPLVpFiF8Miujav/snwE21pRYBrV71H7Z6mChsAs8A7oJoAmGAkp3cZ7bItxGjJengsOGjrWL5+BHeDap0bSxmugo6uMEy/OIqVnvDX21yTY5QhlFPEt/yT1NT30/c9JshHeXijRg6LnYSm9PMkuHghp8RR8QcNaKvYJ+gjDZTz6IUcVP7EQEvA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RwlnS9lZjTMdKRWW+lmIMCfpUGGa6crnU8toIjoToD3qFfGT5uoYUWUJopxOmuKYXwc1JDocihQYNLSNKA6hBBcgPxkGsOiKlyEblvQ95QozruUwNSS4Kf77DAz0Mn0vgENmhG7WOk6rOqvG8EHTMwh1PK5iUArT57s8smAXFlgnj1nXq65Rl463tFPeP5uw2rWAM5Ly44UJjNAnArHDsVG5tfPAoB1bk5B48vmQUj+etDG9i4TapLzgZh/pUrj2JyGJlEmqXDZc1JUFAeJLUoX6JdOMaqKhGsGO+hKEWJqck2+2QLXaRCW0ktpSgGH0xjEPQC0+boTl7u4B3I/5lw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGdcTJ0qha+Cawd2DGnqP3WOqsP3yMBzYxTDCZqUyWC21nM9R5r4OPo7uPBfaMVBKO0SgZXRPXNNq1zmDVguUCmcNXZrCxgqfAxRXL+fm4nOeoJuYe4vOiDshWT/DbNaSW6oEgE91nomxg/R/XBV8WTTSj/ZTGhcovtcKSKaGqRFJyo0GAl6cUaRVGCiR2GVL+TR0j86pNF2Uxj1NpUZFwErQGmTZvtKn0oPSZAlzytc64vTEovfbcVSHzyjDFq73irmr2hPL5N7TdVGO+Yvy3etjgOHyw3lTnYYZmvYneC0CRWs5EYBEcXsUsQs/ZhMjcUY8j9r8UgoocvrPAOFhw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 11 May 2022 14:41:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduA
- Thread-topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3
> On 10 May 2022, at 03:03, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> On Wed, 4 May 2022, Julien Grall wrote:
>>> Do I understand right that it is ok for you if I push one patch mentioning
>>> all the commits done in Linux corresponding to the changes (instead of one
>>> patch per commit) ?
>>
>> For this case yes.
>
> I managed to do a review of the patch by doing a diff of the relevant
> portion of Xen cpufeature.c with Linux cpufeature.c (from commit
> b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux
> sysregs.h (diff -E -b -u).
>
> Everything checks out.
>
> In my opinion, this patch should be split in 2 patches: the changes to
> cpufeature.c and sysregs.c that come from the Linux sources; and the
> updates to cpufeature.h that do not. If you do that you can add my
> reviewed-by to the first patch with the changes from Linux.
>
> The list of individual commit IDs would be nice, but thanksfully the two
> source files are still "diffable" so in my opinion are not required.
I agree with that.
Julien: Do you agree if I just put the changes to cpufeature.h in a separate
patch ?
I started to list the commit IDs corresponding to the changes in Linux and this
would
end up with 5 or more which I do not think would be that useful as the diff can
be easily
done as Stefano mentioned.
>
> I have a couple of comments on the changes to cpufeature.h (the ones not
> from Linux) which I'll reply directly to the patch.
I will answer to them.
Cheers
Bertrand
|
