[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Process for cherry-picking patches from other projects


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Mon, 16 May 2022 15:19:39 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x4isfwTrks12DCtibuSTfKJRdDTgVQxraYV00JzWvOo=; b=b+Usbf/nij5VxsNHNd8oXA+nj89tHj8Zo30JZr4SX3Ns++NIVCZQZ2Dhr70kcZWjsdaSthrUOWpbnmpaNOdOHVYVIgjhDghkbkNmaQmfIvDvmgk4Moy8gL3eu3vtRb0WoBsVNYc5bzXLKEuW3qOBOlxtOL2Yu7itMqQPZStSTJlsHFVUQ4ze94MFt8pffQeRlt1/8o4ogZXpndk90IifFN2WQ0h2Clci0T56spkGxpjM93aZYMBmUh6r85Q+em44acmXMrqn6Y7ykJb7DmxpQvm2y46B3EYZec8hIrAj44TLcm+oXV0Wy+xF/cdtGRcZqklCiJVXna7AjViQ0QVxSg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5FeZg/ZHWePfE+MqIqAVFL0PpYiWBvYNa87L6ydr8zJF+Pf/wheKxAIOLnsV5qh0boZPt520Bjg+uCOv5eu667AeN2v5NmCgpDc6S5X5Xr1SnJT48FpKaGi1otX3kwtShO0ZA0+feIP4woSi22BSip9+Ue76twswvehK4ojNYGXLZImcOLyzETuUSa9iQiYvF136lHFCQcJybrJojok+wty7fbs/Kv/E1hoP1FpaPa9dPPu/US6LeV2TksqFo0H1QZKQZVsnK+IfHlJPA9kQRe8kwuCbTl0Qbpn3CaojWiI/HGNyqTDYdPjueqBsE54wDBvagvpyAbUAyynez3WqQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 16 May 2022 15:20:01 +0000
  • Ironport-data: A9a23:L/oVjqKV7S3u0ryfFE+ReJQlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl zVBCC3DeKqUMyGmS21FGN+3pxsG68XUyYVgQANoripnFn9A9ZGZVYXHf037MynJdZScFUxts sxFNNCecc4+Hi+H90ynY7W4/SYt3qqDTOKU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk Yr7rZ2FNg+s12Z4PjhJsv3Z8x4w5amosj9B71FhOa0S7QPSz3UbMskSdPq7R5farii4PQIYq 8LrluzRErbxpk91Yj+duu+nNBVMGNY+BCDW4pZsc/HKbiNq+2pji87XCNJGMR0N02jQwYgoo DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya fb1ZhJVXB7ePzsROmslBZw7jP2p3yGlfjJh/Qf9SaofuwA/zSRX+Z20aJ/5X4LPQs9Y2EGFu mjB4mL1RAkAM8CSwiaE9XTqgfLTmST8W8QZE7jQGvxC2QXPgDBMTkBGEwLj+pFViWbnMz5bA 2MZ/TAhoO4e6UqvR8HVVBykun+U+BUbXrK8FsVls1DUk/KFuG51AEAmTBdRS/IerfMMRGMY1 AOUr+7bPTVw5ej9pXW1s+38QSmJESofIHIGZCQEZRAY+NSlq4Y25jrlQ8x/CqezgpvQECvp3 jGRhCEkgvMYistj/6em+VHKhRq8q56PSRQ6ji3MRX6s5A59YI+jZqSr5ELd4PIGK5yWJnGRs X5Bl8WA4eQmCZCWiDfLUOgLBKuu5fuOLHvbm1EHN5su7TO24Fa4YJtdpjp5IS9U3t0sfDboZ ArfvF1X7ZoKZH+yN/YvOMS2FtggyrXmGZL9TPfIY9FSY593Mgia4CVpYk3W1Gfo+KQxrZwC1 V6gWZ7EJR4n5W5PlVJam891PWcX+x0D
  • Ironport-hdrordr: A9a23:kXS0PahlxW1TL25AjP4bTQmRxHBQX3Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySaVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNyk3sS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Ln1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoDOCXMsLlUFtzfsHfrWG1TYczGgNnzmpDq1L8eqq iOn/7nBbU115qeRBDynfKn4Xic7N9n0Q6f9bbfuwqtnSWxfkNFN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3amBa/n7/nDE3kbKvNRj+UC3a7FuIYO5bLZvjn99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8PC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8e166MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBkPkoLVeLmzNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7jmZ8 o=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYZtZ1suK3TAKIFU2tuY9R7u+Tcq0hnruAgAAES4A=
  • Thread-topic: Process for cherry-picking patches from other projects


> On May 16, 2022, at 4:04 PM, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
> 
>> 
>> 4) When importing an entire file from an upstream like Linux, what tags do 
>> we need?
> 
> Any clear reference to where it came from.
> 
> Nothing is ever imported verbatim.  If nothing else, paths have to be
> changed, and usually more than that.
> 
> Given that, I do question whether it is appropriate to retain original
> authorship.  The original author did not write a patch for Xen, and what
> gets committed wasn't the patch they wrote.

Not sure what you meant by authorship here — do you mean in the git commit?  In 
the GPL header of the file?

The original author (or the company they work for) may own a copyright on the 
code; if the owner of the copyright comes around and accuses us of 
infringement, we need to be able to a) demonstrate that we are generally trying 
to respect copyright (by requiring people to assert that the copyright question 
is all in order for the handled code) b) be able to track back to find where 
the infringement happened so that we can take appropriate remedial action 
(either education or sanction as appropriate).

I think if the GPL header of the file contains “Copyright YYYY by ${AUTHOR}”, 
that copyright notice should be retained when importing the file.

 -George

Attachment: signature.asc
Description: Message signed with OpenPGP


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.