[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Tue, 17 May 2022 01:21:13 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=d0LVoNNRmyefhdsqfQtTUju5Yl3V0YeJp2B+EeqRmDY36iBITNYpoQTA4h/kL+fptlsfWdHyO4hUk82Cy+nPKC1cwLrH7MtXfLbUlgJ4R3HK07ON3TX9k+vCzf/5eb7VC49nStBtoT6oKx5R41j+d51hvPeKkA5LkC8mCU14Wyadzj2UPlwe0NKTlvEFeaLVCTS4rlTCx+R7GJ6WLRAc1DOTvdd1sonEg/uYFOLG+XaskM6Ja4PGzeJ6Sgsf5nCl2JMCKrKlB9rbhpMp9J+pWgeOn4PwDgICQq14rqrksOxtAo6ny9kYKWArwKoqtYRnmBEp1xyPPb2vCooDTsFj2g==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=OnLvKox8vBvG6cBZ8AxTgoCczDMuqhnXXHmmIQwy4bRjNm8L4a4+zwJCppTrnGcYPqlQIhZqQ2aWcwu3CawlfGFmiUZNF+zC/CVAfDL1PLggrQAsRMNotk5A3NJZZEz1YnL8NTivlIS+YGgGMaOWtjdk5tti7adT00YRV56jTnFME6vIBUHUwWHjIrDdAp0ZZtDq/uJ9OPzryuYwFeYCZ+EfAydrH6sqE3gr0z624WagK4lbn6iq5r65iSNp0c+ZAEukEBBkBMg4D4mMBXpdgGjwTHCz3RdW29EzkOrDmqZJHppJhoxsAm17fRCbvaSnoDrQUMjPDUxjk7mNhA2VRg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UU8zH8pGgToQMOhmcnHEXFXXdio1CRPxxpQnvL5PL59q03EUJ20VKP6AyV6j9ho1kRxVAcbrbS8BrX1Ohpes4sVtx+TdLYqwOk0beaC/23TBd1k8bn9U55IVRsJhSq8t/42ALz+/pqLWPGgvXO5i+5URdpINCGTpFPIsF/lMMB9IQamKq2gk53dsQkdqj/TTnw5Ctc5bMPMGo9h+fDMKiW3p4h4vK+WNf7KWSfAJ1RPfZCtQfYXpm3OvS9BW3jViiKRfwIb+odBfnV5Li6WhnG36Ghmlq8H+awfeJe2Yok0CtZDMmbYabUiYc3ynHxtYnUh2am4bnW3YXgB8ZiRNaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ery3EZ+yqjioBFdvvDrEAvORyyBEm2yrWqA9c6lMJRorjSSa7rr9gcs2V4okkB/6f43hnz/xu4tx3sO0xbNrqW5eaq4rtIkB+HGWFc6TfVrkMm8KAg6iYBw6GE2lRojM/XrEEUxdUHEza/jXuG7J8JX3hTHjgOPHKIxgmBeFhdMVqkrkv6sgPHprpcYsbpxGkNYq/Vl17Wd5e3SciKVELndejg1S2Y2q5xAJPrcC//iFLmLPFnipTmCAqzSsuZ4aBqL+PzDT6zYPc034aoB8SRXucI4pVnupcRK6mX6bcI4zMMlDymZtfZRisWk+8vpdiPMz9alZytH6qCx0QgKcJQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jiamei Xie <Jiamei.Xie@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
  • Delivery-date: Tue, 17 May 2022 01:21:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYZNkH8NyJIpE/PUu9tm96KkUvVa0hxzQAgACHh7A=
  • Thread-topic: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2022年5月17日 1:15
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: nd <nd@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Bertrand
> Marquis <Bertrand.Marquis@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Jiamei Xie <Jiamei.Xie@xxxxxxx>; Julien
> Grall <jgrall@xxxxxxxxxx>
> Subject: Re: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from
> early uart
> 
> Hi,
> 
> On 11/05/2022 02:46, Wei Chen wrote:
> > Current putn function that is using for early print
> > only can print low 32-bit of AArch64 register. This
> > will lose some important messages while debugging
> > with early console. For example:
> > (XEN) Bringing up CPU5
> > - CPU 0000000100000100 booting -
> > Will be truncated to
> > (XEN) Bringing up CPU5
> > - CPU 00000100 booting -
> >
> > In this patch, we increased the print loops and shift
> > bits to make putn print 64-bit number.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > Tested-by: Jiamei Xie <jiamei.xie@xxxxxxx>
> > Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> I have committed this patch.
> 
> Patch #3 looks to be suitably acked but I am not sure whether it can be
> committed before #2. So I didn't commit it.
> 

No, it depends on patch#2 to provide EFI stubs for Arm32, otherwise
Arm32 will be failed on building.

Cheers,
Wei Chen

> Please let me know if it can be.
> 
> Cheers,
> 
> --
> Julien Grall

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.