[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/mwait-idle: add missing newline
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 May 2022 16:29:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bVi3TvLbsnmSudnG95FiDbbbRq9+n3Wg/cRuoNp7Y7w=; b=fvuQJPCtkZS++BnvYLl9kywOrr/AlPfd9VBYqOQCE7Si4R47unqGGYoitZD1Wp7aJcMjq6KxKLBZAGuxQJXq03cf7qFL1AwOn3h3/3nczb3GmU3HjjFx7aB7Dj3gCT8fVOZ6YHZDRQmwxsysOnQ11tMlAJuppvuQd9i14RIZ998Te+iYT2cXJHtavG69asuJP/VDjvQ3Xlv4APbuM59dPLS19oIbV4THdOBTahKQEozB/ZZa+Mx4hDXKSQ0x5hs+XU7iLwp7hgvkjvcy24Yopc273P9QPavC+U7IXQ43QSdKU4NDr45Wa1BWIw4Eo82BWb8gfChcgrgvs7dlZtxFfA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dM95Dxu3EwwSsM8tF7P72UsPkKfh5LxIqiTQqYBh4n/Es7B94YEH2EMOedk8GL2Rtk1+73WYWag0W8guhiztjfWPPRqkd+Vxcygb/tpbjoJnadi5rmPlQkdtZWn90J98GZJG+dkCIJA4RtJW3Or+t6j2gXahLFxzVoMUlV5CBuvQmmdLwJ5kWXeFfWXAPyB7eDqKC7Hcv+ICkcB2tCv7gi+teI5LfycU1f4MHEu1bTI37CXFZRwBaYWdoFHWcu0FaUh1e0gq+PzLJk27XB0Yeaior4+8psoIQeHg4pkjHDrWYJjoOOwhUla0no1fpMGyohTJT+YcKziVPp0y5G8EyQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 May 2022 14:29:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.05.2022 12:36, Roger Pau Monne wrote:
> Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10
> enabled')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks for spotting. I wonder whether we shouldn't mention the Linux
commit (654d08a42a56) which did this as a "side effect". Obviously
the fix here isn't really a port thereof.
Jan
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init(
> /* if state marked as disabled, skip it */
> if (cpuidle_state_table[cstate].flags &
> CPUIDLE_FLAG_DISABLED) {
> - printk(XENLOG_DEBUG PREFIX "state %s is disabled",
> + printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
> cpuidle_state_table[cstate].name);
> continue;
> }
|
