[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 17 May 2022 16:48:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BU1iE8uiEduxFiLngPWmZPLIrI3cSdCmzeRl/3TB6Vw=; b=fTdfCq9pM7by95YU+71qR2MERbiu0aIwXOSOlWOjgkFsDrnD7fm2V8Hp+GtycHHPB3HrYvamGK56ygJfdaa+n/z+wreqbVvtCT+lIO29+VToGiDq9vK4sDf6POS8h7OK16HJ0EcTWkAkftWOOjo+0fMzVliZbufQBppkDAaFGsePb1vBZLiSdlWEFKz9j6ttFK99JCt++iuf+Ly9netMSqa68MtcfrCe1/F4HpltCQX6WDsuKPgymA+9uusOkk8dQ41ilVMhYDilUDD2C9SOtv+W31ZyzLzsHlLGJvnq/rgqWkgUz1DgNUYL32W4mubQ/xX4+huu4UvleWvvT+H/Iw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=No3w5fdbz+aQ0SgcVJ43SgMuSBmw4wpJcagCNWE2GqkASduBpjCUT1DSrzW+Jzl0VDWMORpA4y3dAK+lDpVCbonGKmKqH+fHLrgYULn34mrZ4/N/+xNR3YBthyHAb4eQRXQ+ZeDH1LSsFc8GL7VGIwtK02vW+DCeDpKtGPeYH7km6NtaVeLgcf9XxX6EN+Sj5CxJzpfKGTbhTLax8Vo0TCoTbpGH+qlhvoseH/knk3E7wMY9/qvstCiTx3/DVjhj83EltPB06f07YyHOsaREm71iQaCc0gb5cxVnS/dg6ksLqgGIbXCeW/9hjwtIz0kOt2GQyTb5GhmVs6dvN/9bFg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 May 2022 14:48:50 +0000
- Ironport-data: A9a23:zSb2VaMiAiO77HbvrR2alsFynXyQoLVcMsEvi/4bfWQNrUoh02RRm msYCmvUafuJYDOjfN4ka4i18EhUupfRyt9jSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Ew27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw 4hdlJzpZAATHKiSmO5adUBXFzt+MvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/+iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33ySmK2wH8Tp5o4IL42L3lwUv+oPzPfqPYtbXdMkWwQGH8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZviUeWz3YeCzUXU0W6uvizjkOiW9NZJ FcQ8yBopq83nGSpU938UhuQsHOC+BkGVLJ4CPYm4QuAzq7V5QexBWUeSDNFLts8u6ceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9jqQzf5x mnSqDBk3u1Jy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDDhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:E+Dy6KzcKlSOt1/uUTqaKrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1rop5PzuN5d3B+3Z W0Dk1ZrsAxciYoV9MMOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote:
> On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote:
> > --- a/xen/drivers/char/ns16550.c
> > +++ b/xen/drivers/char/ns16550.c
> > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t
> > skip_amt, unsigned int idx)
> > pci_conf_read8(PCI_SBDF(0, b, d, f),
> > PCI_INTERRUPT_LINE) : 0;
> >
> > + if ( uart->irq == 0xff )
> > + uart->irq = 0;
> > + if ( !uart->irq )
> > + printk(XENLOG_INFO
> > + "ns16550: %pp no legacy IRQ, using poll mode\n",
> > + &PCI_SBDF(0, b, d, f));
> > +
> > return 0;
> > }
> > }
>
> While this code is inside a CONFIG_HAS_PCI conditional, I still
> think - as was previously suggested - that the 1st if() should be
> inside a CONFIG_X86 conditional, to not leave a trap for other
> architectures to fall into.
The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86
region already.
Thanks, Roger.
|
