[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 May 2022 18:01:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5v3G3+BraA82fxzDjxTDmF9Gk+PZLfgeFYLnG4c6WE=; b=YY2lMyyQf+dEq7lNdDZMxSzBHmwX/rO2sslFIU2O5u5oLBJNkGcaaFFDgfMHMRNNsobs+G0d6R703ExmDevvjNHdjhqTOnOxc0x7Ok68Y8rVZWxmFqZFxYO8TWoNjCU80BLGxRbwv8w9fLZRIe3lRLyYOnYBcJ8euh2NwDJSpH18s31EpDO+8bT97Bj3d5gels0Fk6RmuO872XHebbKDXy164fhQlr7K7c41fAnIcDDVw2NlCqyGTbQ6+dZT2rCA2x417c4vP5UttG4zvXdU/gu+5QTw2R69pCQ7+MYyZQ9bcEmdL3TZowWS8c7JL9S0F1qM7t/fSUtUsf2g2FJC2Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB70hOWRanEIeNYo0ESI1xQVxyzPMqCLZhSghlckgaKnt5uFmxM6MRIpvAUPMJ1kybWtS03CMwAsNiltyjI8irYx/c1UhCMvkUlHbER1/0ageHBwJfncabXLawz5fau1PVsPgeQTC93e/ZjQRhzoJz8QwmnZ459IjrrVhxBWozBApCIgpCOPV2POtInMUsZ/WXd0YyJe863hQ5i3nIcu055rIKRP655HMrdqZchNDTA5rWvMF/bbjdALTqmSEErA/YEfc+nbtwwtu2i6InpdmBLmJx0xNagn0tef84PwuO1PXPIpXKakyCvX+QhGfkDDipBaJgwVmfZxhrFMzKbVuA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 May 2022 16:01:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.05.2022 11:05, Penny Zheng wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -780,6 +780,11 @@ void __init setup_system_domains(void)
> * This domain owns I/O pages that are within the range of the page_info
> * array. Mappings occur at the priv of the caller.
> * Quarantined PCI devices will be associated with this domain.
> + *
> + * DOMID_IO could also be used for mapping memory when no explicit
> + * domain is specified.
> + * For instance, DOMID_IO is the owner of memory pre-shared among
> + * multiple domains at boot time, when no explicit owner is specified.
> */
> dom_io = domain_create(DOMID_IO, NULL, 0);
> if ( IS_ERR(dom_io) )
I'm sorry: The comment change is definitely better now than it was, but it
is still written in a way requiring further knowledge to understand what
it talks about. Without further context, "when no explicit domain is
specified" only raises questions. I would have tried to make a suggestion,
but I can't really figure what it is that you want to get across here.
Jan
|
