[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/6] xen: do not free reserved memory into heap
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 May 2022 18:11:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZzeCh0pPrXtu0rUV3W/FXa8ThGf/mCGGbhst6Ctq+0=; b=LeOSfk+vmpqfbXgQrGPQdxM3c6HrpXejeM0tV37IUNht+KP5qhxsIamOlZkrcl0BPXwXjxuSd4JTQ6R95FLXkFu9cBVm3tiaxrt/7RG7jgFv8Ci/2f/AKn+Aq2wmoXremwyXQdMj0X2lCK1Y4NHZlMHG22INRZV/a5weACcdkP2OTih3zepeKVjMaYbsOZD0IHx1spa/HbVYcEwbAR9y1m+sEjCl5vS+4rdFvglSawURwZOfLP4v/iNyn670SO7T7Cx4tC/wjPAHzbvEioRgqv1OnreTtT+kDMga8wifm/lqH3y8yP4ERv40Md8RUYJPJCtBW0jpHq0yMkqrATtvBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OL0D+ttCdbixlF6c0YHMUUlteUXI98/KWX81IW7LoT+3joheLbLRbOXKYfRPfIIhNVcrPCDPl1c/O352tJOMPPjGAWLfdJTB1cTa5Gh7jYD7m0cBoeyYh9N1fQxpSDnjGqXMy1pdw1TXMTHdalhGkyVZGIFZTJQo6wPJpXU9rdLNwE4eqFv+jKivNqLcSHR+C2klWuoswjD/XcNXePco6aBbrVc3ES0IF6Hp1sxw2XK26A9ywf3gBWERDQcOrKDwzsavlvYIpCq2gAOdDj0Ig8xM/69P/Jl3KhKwWjjtKI1s+HSt3+PhnRw6OlCzzJIsBKhReQpE/cL9HTuLbuI8Nw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 May 2022 16:11:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.05.2022 04:27, Penny Zheng wrote:
> @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d,
> mfn_t smfn,
>
> return 0;
> }
> +#else
> +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
> + bool need_scrub)
> +{
> + ASSERT_UNREACHABLE();
> +}
> #endif
As before I do not agree that we need this (or similar) stub functions. As
already suggested I think that instead Arm wants to #define PGC_reserved
(to non-zero) only when !CONFIG_STATIC_MEMORY, just like is already the
case on x86.
Jan
|
