[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 18 May 2022 09:51:30 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=k7zkqOUukw6MZ1E9nu3qmxYvr4pOZ4GTYkE5dYuktTrI4yETiM2vgpOBRu4i1hGsxOcTsZwGZ3QfS4Y90CuX5K8RBRD9n3pyrcatr7OARPLFJoMVTwXxMx27cD7C5buBVHqjI7cZlGHPxlb6gZ9RmBxc06pX7tzXzfvy8AnIGm43ahIVs7Puq50VYsu4smuFkr8hGYmtAdXwFMUVpLUu2azhOFJCAbXuJlNg6cbL5MVcGSlC8JZCzZ/YyzbRIdYdeTAHeJnLkEJzuSN5HBmzIPXGYnEnUh28LaSnF6mNgGNdwPMmePoDjt0do1QuiEkiIwV4p8VZARIR8qLACEDC4g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=HgEPMKn/e1u4rVTEQzL8AD996nEhZROg7h1WrtdcoKqk+gnicwfLvu8FBuGsVAtC/xSs0G/y9b7f2IbTxB8AhEi7DLGA7OhuB0mdNJWIc1lxCz0okL5ExGWjKzp/7dEsdS+l9dz69NpljuNJCNoj+6wP3tHNJOTb0CroCGIT7F/PjUqCd1tFWm4badmA5PNvDsi3n+IUnNDkyoEF/EPxdOI2LLE4HjWXfzaS+BV71PrueHgnlJ93gjFCX/Z2/NdSB/U9fWH9DD4c7ptUV/7BUEXTTxErGhGlLfMUvoFcug0TWxOiXWG+KqwfZ0C3ii5zr2kKx+XV1/08rMfyhDnSiQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Tooc3TRk8d1pt3dU9Wlu46SuaCaeXhN+O41DG+6bbvGHSBoTrWMqItvhV+nfWCQ4eLtGBPdChejrUaUAXAaw6ggPxnqWEXOzon98Y1rWHFA4Aj5U+3yslMkRQUYFRGBo23rxL/d5aDYim/BzevZYEvhhX4RIIcq1tLR/XG3unvuqorj54a8juzR1IZVY7lCxQYPdn7dr6TKBuvYQArzru15yHBscER2lLeF85VM8y2TqdpmgTWZLyP9EY5xoMypdqXlxjit21U1dtZKPKJBtKj+h8NC8PvlxPZaIvPEE5ooXoSWvkGQDAMgca4we1EQSTRX3lTlOZirY2YWn7eZ+PA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RhnC7wImcM0dAcF8OT1MG9ahngODwJyALH+Lx3+WcSssn3SMLXvOTBYCVN60mZuRMxNjiC3PsIdrMQNTjHl0bzTw4pj9zlIHhx35MOk3+wayCQeTcQyJlgKeqfV3jfwqanagquFT52iAVfQvOaG5EgNiAAZCJZhNuJGr/0SsJofp0Obb00QQx04M6AYlWKtrnWuU27p8GSkn32KnaeQB0icC0wpedMkbF6QATcb8ogpmob74e2ee5/OYhYl2epkVYeBtNrjG0k9GrCi9IQiG64zZSs35Yu3x5r21uJtBAFcEM4vLbA1aQHEusyR/M31mwt1pQRnP1yhvj6YwknaUMA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 18 May 2022 09:51:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYagM6tDpJ92rV50ONWDPDxej1sa0kY+2AgAABBzA=
- Thread-topic: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
Hi Jan, Roger and Andrew,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
>
> On 17.05.2022 17:31, Roger Pau Monne wrote:
> > Hello,
> >
> > The following series implements support for MSR_VIRT_SPEC_CTRL
> > (VIRT_SSBD) on different AMD CPU families.
> >
> > Note that the support is added backwards, starting with the newer CPUs
> > that support MSR_SPEC_CTRL and moving to the older ones either using
> > MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG.
> >
> > Xen is still free to use it's own SSBD setting, as the selection is
> > context switched on vm{entry,exit}.
> >
> > On Zen2 and later, SPEC_CTRL.SSBD should exist and should be used in
> > preference to VIRT_SPEC_CTRL.SSBD. However, for migration
> > compatibility, Xen offers VIRT_SSBD to guests (in the max cpuid policy,
> > not default) implemented in terms of SPEC_CTRL.SSBD.
> >
> > On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to
> > abstract away the model and/or hypervisor specific differences in
> > MSR_LS_CFG/MSR_VIRT_SPEC_CTRL.
> >
> > So the implementation of VIRT_SSBD exposed to HVM guests will use one
> of
> > the following underlying mechanisms, in the preference order listed
> > below:
> >
> > * SPEC_CTRL.SSBD: patch 1
> > * VIRT_SPEC_CTRL.SSBD: patch 2.
> > * Non-architectural way using LS_CFG: patch 3.
> >
> > NB: patch 3 introduces some logic in GIF=0 context, such logic has been
> > kept to a minimum due to the special context it's running on.
> >
> > Roger Pau Monne (3):
> > amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of
> SPEC_CTRL
> > amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
> > amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
>
> FTAOD, while besides a missing ack for ...
>
> > CHANGELOG.md | 3 +
>
> ... this addition the series would now look to be ready to go in,
> I'd like to have some form of confirmation by you, Andrew, that
> you now view this as meeting the comments you gave on an earlier
> version.
Not completely sure if I am proper to do that but for the CHANGELOG.md
change:
Acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Jan
|
