[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 18 May 2022 10:30:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=eHViKsD6j4IcEZ8Y5DQxGtSOZHrhEErH+qdo1veo9uNF12pBqvwx24pMyZaKvwQ97aCkJWAxsLAMsyol30R/KIxl6n4OnyX8TjPE8WpFDMf+XNM1Bj3KXGtA0wa174N/MLwJbSSJjW8SKNAmmOHbF6BOwUgkLzBxEn9hOdzACAHu9U8NmItCUH3ka6NyctJBgePpg4AThU7E0UxlcFV+Q6k6EfrKsXdcT6RhO7J6L+L0SmLGjQxTCnmbIq23xB43XuAGachkAWLyREzTVcP2gzsHpQntJ6pydWcZJxPqb3eyaheUwM1pOwvNwZrUPRQAkM15TpVDRG3IoMX1TvDlfA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=Pw9Tp8OkRgtQbP/Vd94JJtooELYM/zSBhP0ZMstascMnHSKyrEVv8fc2Jsgfyu4VADPsV+uRqMmZExqvNjcVbdOl2wGEmFqshfwVTtQtGdc+XsZ2RxgAVCnc+PMxJtsMYyjtxNV/CCimFuz3L9z+ueOBI4+MKEOgqBpihBUxiYrTAfa3a22PFMpXbRQMIY7X++OBSlFBaoSSG5cYN6glwt5EEUDESqNVRssd+7e9VZQxZpP7wJaN/2eUsrWLQHiaFXLRTDzzVle7HCd0poHVXofXNX7E98hBypbp3G1+QVyOCOE2t+vTEKLtoFq3cr2xdIzvmSIUfFKRB31iKgVUrA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gJeiYDRgmKjEMdLgnwCa4NcDZECUEHA2NUWYIrsc52qpdCyHP1L40cM4sK7/vGWzY/kPcEyyQaVWh4qNn61piq5yYZUAEBD1tROTFh3LZt7/bXzNHamvxVACEjlk0t97cgi7aIzRcWS0h4lEVDJuMtHtrIGUZmd2rGTmKjiODSO10Dbxo13BEiy7kS6dbSg+W7Mpmj3BIHRF3lHLO6uv3vm3cKCKokmUgL76AYDImpXqzANcaGIelowcX8+1v8oMFt9qvPbZWD2aY9BQIM3SB60WKZnYKxsNa1zB1uK4IZiCwk25309FzgLzLr9jhJLRGYDbWwixXvTB4I2rrLGrVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htMw2NHrwKFwubg/OrC+HCJsgQi4wHlYAiUNi85vzzdlGLN4VA8iDVWB0BQxcFNjyAXhYsiIPu5/TaFxBkQhJXAuJy1CwjqA0mtmdb4lV3LV7OT4cPowinylQjWnVsInSZghh6ko1Z1eF48fs5W41YWqIh5u4hoFnS1pkpsbbFYGMXfbOCfkE6KjA/0kVWzGJaWbP1J6Lx6KVCw4i7/imXclo+Q241EZPLThC5QaN3hlUXcckXZDkmP3ZKZzLjK7Ikre2AFui5WG0b3X4Uc9/pqyzLnzxuaggAct2ILJpcv3tttEA+4/TAi9efO7Et6GwfVPu/Mew2qq8YCZ7ZcGyg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Edwin Torok <edvin.torok@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>
- Delivery-date: Wed, 18 May 2022 10:30:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYaiYlhlRp70KGIk+7qOp/vtrSaK0kZYcAgAAF1oCAAATWAA==
- Thread-topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id
> On 18 May 2022, at 11:12, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>
> On 18/05/2022 10:51, Edwin Torok wrote:
>>> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
>>> index 7503031d8f61..8eab6f60eb14 100644
>>> --- a/tools/ocaml/libs/xc/xenctrl.ml
>>> +++ b/tools/ocaml/libs/xc/xenctrl.ml
>>> @@ -85,6 +85,7 @@ type domctl_create_config =
>>> max_grant_frames: int;
>>> max_maptrack_frames: int;
>>> max_grant_version: int;
>>> + cpupool_id: int32;
>> What are the valid values for a CPU pool id, in particular what value should
>> be passed here to get back the behaviour prior to these changes in Xen?
>> (i.e. would it be cpu pool id 0 or -1 if cpu pools aren't otherwise
>> explicitly configured on the system)
>
> cpupools are a non-optional construct in Xen.
>
> By default, one cpupool exists, with the id 0, using the default
> scheduler covering all pCPUs, and dom0 is constructed in this cpupool.
>
> Passing 0 here is the backwards compatible option.
>
> And on that note, Luca, you ought to patch xl/libxl to apply the pool=
> setting directly during domain create, rather than depending on cpupool
> 0 existing and moving the domain later.
Is it an enhancement or a bug fix? From what I know, please correct me if I’m
wrong, cpupool0
Is always present, so there won’t be problem on assuming its existence
>
> ~Andrew
|
