[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: get rid of blk->guest_block_size
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: "Durrant, Paul" <xadimgnik@xxxxxxxxx>
- Date: Wed, 18 May 2022 15:15:50 +0100
- Cc: Paul Durrant <paul@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-block@xxxxxxxxxx, Fam Zheng <fam@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Xie Yongji <xieyongji@xxxxxxxxxxxxx>
- Delivery-date: Wed, 18 May 2022 14:15:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/05/2022 14:09, Stefan Hajnoczi wrote:
Commit 1b7fd729559c ("block: rename buffer_alignment to
guest_block_size") noted:
At this point, the field is set by the device emulation, but completely
ignored by the block layer.
The last time the value of buffer_alignment/guest_block_size was
actually used was before commit 339064d50639 ("block: Don't use guest
sector size for qemu_blockalign()").
This value has not been used since 2013. Get rid of it.
Cc: Xie Yongji <xieyongji@xxxxxxxxxxxxx>
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Xen part...
Reviewed-by: Paul Durrant <paul@xxxxxxx>
|
