[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor


  • To: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 19 May 2022 08:03:53 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBttHXc9Bah/LeexF21QC1EdU+43Kka3upiCyrlpYO4=; b=nXzREZfDozzunRhruFNm5C0HC5oU3Uhmb4jdml1CdX8q0hXtvWRgdE7jElQaIi8xnIE1YGUiIhwJ1i7/gDurIrQrN5UzBIkl+OWAI1Rrkeb4mQLMrvbTjTeu5Zncj0WLVh2nLCHc9TmilmzTzjGSKZrWcEf3At3fAMOmwqx5o52FBuVeGeXYb9yM9YVSdqg1VxOYS/Th/6rEVWycI7QT3vzzUfd6GOoPgU+ieMCu7+LB/ttw9jJ24q+rkhfO/p8jQVMb9fsdRIOSHo0Ki+9C49pofl6R7Qm3e8/xIXbVS5wk0eLz0UiN5dpCd76dHDgysUKLhrxgSYsWYahPdEfBrw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LH6X5j15PzAzLVIzSUmkkdAZKOu5Exve+AtJy05a+TGJoIrX4zJsRw5rMN4OUmSQPKc8oJsE+9P7tC65KF9ubCD210rtf1CQHF690lNMx5o5Uy5eKSGzwLhqed8Wujig+omQGcysxXjs/q7B/J9SFP0l8NqtuDz23W23izznwOgXFeKVCLuF8og5w12f5/W4GnYpLvlaVdd2u+roBIMSU7JbElj1hwGWSV9hgBRA2xq7RFDx3Jafv2hQfKqnCPOQIKy2TPEyRAeAtJAS+BL/19HBt/nThG+9XaJu0XMbAXO2Jh1udF/724wsAQuMZgUhGT3RszsDTpATs1Gv5rUQKw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 19 May 2022 06:04:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.05.2022 19:03, Tamas K Lengyel wrote:
> On Wed, May 18, 2022 at 11:48 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 18.05.2022 17:01, Tamas K Lengyel wrote:
>>> On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel
>>> <tamas.k.lengyel@xxxxxxxxx> wrote:
>>>>
>>>> On Thu, May 5, 2022 at 4:27 AM Roger Pau Monné <roger.pau@xxxxxxxxxx> 
>>>> wrote:
>>>>>
>>>>> On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote:
>>>>>> Need to separately specify if the reset is for the memory or for the VM 
>>>>>> state,
>>>>>> or both.
>>>>>>
>>>>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
>>>>>
>>>>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>>>
>>>> Patch ping. Can this patch be merged please?
>>>
>>> Patch ping.
>>
>> Your mail (and I guess also your earlier one) was _To_ Roger, which
>> is odd since he already did provide R-b. What you're missing is a
>> tool stack maintainer ack aiui, so it may help if you send your
>> pings _To_ the respective people.
> 
> True, but all the toolstack maintainers have been CC-d from the start.
> Is it the case that CC-ing is now officially insufficient?

No - patch submissions should still only Cc maintainers. But I think
pings, especially repeated ones, would better go To the respective
people. (And this follows my general remark I keep making every once
in a while: There's a reason there is both To and Cc, and using them
appropriately can help. Of course there's no guarantee, as people
may not pay attention at all.)

> What's the
> point of ./scripts/add_maintainers.pl then which specifically adds
> maintainers only as CC? How are you supposed to get their attention?
> Just know you specifically have to send emails to them and not the
> mailinglist? I'm getting the distinct impression that the toolstack
> side has simply become unmaintained/orphaned with no one left who
> actually is looking at the mailinglist.

While things are far from ideal (and as you likely know we're still
looking for a 2nd tool stack maintainer), I have actually got the
impression that things have improved a little lately.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.