[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class


  • To: Bernhard Beschow <shentey@xxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 19 May 2022 15:29:42 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <qemu-devel@xxxxxxxxxx>, <qemu-trivial@xxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, "open list:IDE" <qemu-block@xxxxxxxxxx>
  • Delivery-date: Thu, 19 May 2022 14:30:11 +0000
  • Ironport-data: A9a23:v3GPyqzBMmFL99XFBYd6t+dowSrEfRIJ4+MujC+fZmUNrF6WrkVWy zEZXziPM/vYZzanf9skOYuy9EkB6JSGytNkG1dsqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12InhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplm4WdSy1wAZL1le1MahQFOjk9Eb140eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6BP ZJINms/PHwsZTUfEFE6NbwXld6npXDOXmRakUy/lfEetj27IAtZj+G2bYu9lsaxbcBOgm6Cq 27G9ni/CRYfXPSSxSeM6H6rru/GlyD8Q55UErCkntZwgVaTz3YfTh0bU1e2u+K+jGa6WtRWM UtS/TAhxYAr+Um2C9P5WBa7iHiDuBEaRpxXCeJSwAOWzK3LyxyUCmgNUnhKb9lOnMo/Xzcn0 hmAh93kATZmrbi9RneU97PSpjS3UQANJ2gEdy4CTCMf7tXjqZ11hRXKJv56Hauoy8HvGC/xy jSiqi84iLMOy8kR2M2T5F3Cnnegq4bESiYz4QPYWH/j6Rl2DKa+Z4Gu9VXKxflFJYedCFKGu RAsi8WYqewDE5yJvCiMW/kWWqGk4e6fNz/RikIpGIMunxy18mOnVZBd5nd5PkgBGt0fZTbjb UvXuAVQzJxeJn2naelweY3ZNigx5fG+T5K/DKmSN4cQJMgqHOOawM1wTWCJ8mLHyXcTqKw2a K6WLO+0TloKN40ymVJaWNwh+bMswyk/w0baSpb60wmr3NKiWZKFdVsWGADQN75ktctotC2Qq o8CbJXSl32zRcWkOkHqHZgvwUfmxJTRLbT/sIRpe+GKOWKK80lxWqaKkdvNl2GI9pm5d9skH FngAye0K3Kl3BUrzDlmjVg6MdvSsW5X9y5TAMDVFQ/AN4IfSYiu9rwDUJA8YKMq8udupdYtE aRfK5zaXqkWFG+fk9j4UXUahNUyHClHeCrUZ3b1CNTBV8AIq/P1Fi/MIVK0qXhm4tufvsoiu bywvj43srJYLzmO+P3+Mar1p3vo5CB1sLsrAyPgf4kCEG2xodMCA3Gg0ZcKzzQkdEyrKs2yj F3NX3/1ZIDl/ucIzTU+rfnU8NjyS7EmRSK33QDztN6LCMUTxUL7qacobQpCVWq1uL/ckEl6W dho8g==
  • Ironport-hdrordr: A9a23:OeyjjKD0QigQIbzlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN 5dmsNFaOEYY2IVsfrH
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, May 13, 2022 at 08:09:55PM +0200, Bernhard Beschow wrote:
> Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci
> generic class init function' already resolved redundant code which in
> turn rendered piix3-ide-xen redundant.
> 
> Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>

Creating a guest and migrating a guest seems to work fine without
"piix3-ide-xen", and I can't find this name used outside of QEMU. So I
guess it's fine to remove it.

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.