[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: Fix make warning if there is no cppcheck
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 20 May 2022 12:10:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=A9VyhjhXNrzs69ZCOCa6wZrPyr+VGxla81TM72T95+7rfWnALWrdpfUOEg8Z3vhG9IkdXX5ytjFGHqjFlcfRMGSRbFD3EEcSsTLPCwsPt2EAlI6151FUAW7y9YbOyFViBMS6JAxxiwSY4U+Cgk2xUY0fdV2bs//uXwH9a0sSnM4VR+AMIyRK6pGiU57ylSOUUDBmdPtEHC0rge5AjZcSGJnxnTtq0lwNeEuF9VGpmWNzP9zlldQQbOyy/gAjjj706cWjx4uwsGFR6oqq5DpjeWWfuFOdNCXPzfEnap0dlh9IIY0jYgtSJ7hChZnHB9AlrIn8oC3a0m6+rR3t4DRw+Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=cIsmfQm1th5Xfe6pSosSOGzCLZ6hbO7JW4/RqDCamywZnarVu7LFGPLrYGvLO1NrZ8PcHZDKxPjiM7uDXfQDmHSS4xudk2rxPOj9wWP0iy2vIw9tpZTm8pJlHpWjFIfkLc0p7Ahk7DU/J0GBP0pA/rzzqgcEnXdYqXsh0t+K/YTDqKmBLXrMiaonemXIjk3zkkbpbN43PmIlHFxcFKx82U1WAxTgliHe3WGepQjezklP4Yv/LRrV+3oTW9dOqtJT2GUDGdOvxR7zpXhyDNz9dNuJmkou+Fyo1R1aRM4xQRpfb6FOwZcj8MD2M+R/SgqbrYtMSYLLxO+mdkCTh/R/Pw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y1igTrvLoc+ELxafe9dopGEnKPYvtPn1BLEPWEY+SEnz4JAR7kIfypj3neQqo1QB2FjmjqhdvJ5uOfPkEH4pNHvdeJarhwPCdgQTPSRGTvRWR2SquOVO4+2x2SfSKWLMO84tboDCEp/NfwRzBaonp+CEUmPrcnJasIop7lUetoah/ivq9liG6AGT/lHOQjMnVquTXkT1hKXe2tK14ccr+N9siqBs2cYujAtSRGqCBa3YUwHhptoKWUaIv5P71YtDW+i6XqsqGXMPsJnDNWfrjd70ZjFUxuBWVUXg7F1aapWlQkcKF1xKsqmvTYB0yKWUbt2xT4+LyuaGPIYcQ1Erlw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EBkjvIorzCge3jmc+9vOYfG1qbp4Y9x9ngmIOGOuljgPGDTDSELsa2dSaRXtpuloZM4pZXO4i/dRmpNQY2WBBvNq0k0SeMtUFfmFkTVsGQ/5Nu5jls4kOGfHFdsX1betxa8kHsd8c8qhXg3wHkmr5IQTPjJOv0V3sXamoSzXofoTDn2vl+Pxzm2IhSXmmkSjKOe5XtEF+yQqg1G1JHFI2QSEavA96bNGD4ONZPT/wWBugz/q0HnZXvaiAE77hIsGKbXzrhceOq3T74yfm4ih1GYTk73cFR/A54xZIIhp/tuDvRpEAxVJh3fZ/xtC5gemEXVcmLqBIP7laT6xz0QgpA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 May 2022 12:12:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYbDdo2r5944WyY064u79v8h3JAa0nmuqAgAAR9IA=
- Thread-topic: [PATCH] build: Fix make warning if there is no cppcheck
Hi Jan,
> On 20 May 2022, at 12:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 20.05.2022 12:49, Bertrand Marquis wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c
>> $(objtree)/include/generated/autoconf.h
>> $(call if_changed,cppcheck_xml)
>>
>> cppcheck-version:
>> -ifeq ($(shell which $(CPPCHECK)),)
>> +ifeq ($(shell which $(CPPCHECK) 2> /dev/null),)
>> $(error Cannot find cppcheck executable: $(CPPCHECK))
>> -endif
>> +else
>> ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
>> $(error Please upgrade your cppcheck to version 2.7 or greater)
>> endif
>> +endif
>
> While I agree this will silence things, I still would prefer if you
> switched to $(if ...) inside the rule - there's no need to invoke the
> shell while parsing the makefile. Anything like this only needlessly
> slows down the build. Not by much, but it sums up.
I will submit a v2 to solve this properly.
Cheers
Bertrand
>
> Jan
>
|
