[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/6] xen: Switch to byteswap
- To: Julien Grall <julien@xxxxxxx>, Lin Liu <lin.liu@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 May 2022 13:09:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnZoSPwy+gnzOQAbNFy5J4GpHhb1nV8TUO/EjW/tHfk=; b=lwgNp0axxkKYD6zpS/ratacyFJ8Z1elvYKKWvhO73qXTifXhUbr6buFYPGnRDLcEeCXGvT04vyHuRp1jyA5qE0QNCSYVMnmOKo6LRB+t5AP2Wcw5btX+8leSj9P2nyntqYPlDq7u4fkDgta9Cg7vF5gQUlWnbt9TJYVoJM8TQ/x+fc54csvunLM1vpVihEAN/CSb+BGTyIvlmZHIg8wDBgEn96gPxNhDxX2UxMd1T31133ODanP5KFU78nxGOCw4vE03jwYjOsNPq0o2WDUMirO1dG98s2I0IY3RpdGT9dkSJmudfpcCeb66aBFUZCls7LGjAIDKR6/Qd72rYxATKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O44PVkPBYRQNZ4NzB/pqgCxuKh8hzlGZVUUIGLS6H0V9U2bNAv9XsMaoCmaH8YSP2QqPuq5/bQ4r3VvLiRfeNCDhB1+c04TvSA1miYOmdPcXTHRNVo9TfvcEnspnMw7tFHv58hWhB8tbz6Crm4YgDtN8aj0/mf3aTg7wcdzT9cRyClmWgsRgKdJETVPol1pORyegY4I7N1qL7cZRNklQ782i3KvvPD4YjbqdXnIgN/w922q4w7uVGCoBDtWuVpoaSMNKRknKJ7ETDjCWcxAIyBPVN0EN2A/Cc65A2RFA135rbZ64DM1mus+L1WYk/f6HGth3TSHqAh86gca3Kgl9BA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 May 2022 11:09:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2022 12:12, Julien Grall wrote:
> On 23/05/2022 10:52, Lin Liu wrote:
>> Update to use byteswap to swap bytes.
>
> I am still objecting on switching from be*_to_cpup() to be*_to_cpu().
And I agree. Especially the cast to explicitly aligned types in
get_unaligned_*() is rather unhelpful (and kind of a lie) imo.
Jan
> I will not Nack, however the strict minimum is to explain why you want
> to replace the helpers as I think the reason that was currently provided
> is incorrect.
>
> Cheers,
>
|
