[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/6] xen: Switch to byteswap
- To: Julien Grall <julien@xxxxxxx>, Lin Liu （刘林） <lin.liu@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 23 May 2022 15:38:24 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0th3acWlvmeJ7eA6A4XDR4zJeEt6USaJWRfKMgTsRxM=; b=B0O04L5cO+QdAwy+HZw6MbqFDs0NWBQJfFGIHofXgyLozUJW0qNtSvLo3z9X0ID+TVaXEYIJY2dTmiWNucMC6lYdsHwOW/1Qo24fkDckJ6t4hxZLlN0iM3og+SAjjrAL2ccU138KXZdNXS/LKSXZKL4FUxIIn6lGSKIRlGp/Cw0hl9TCrkhxpqAuDPOTR8jT4m8oWJFOpnjeodmZASuL0yBdOt1UskYppaYApfqxrvGUMEyVBGQpuE2L50/HArgTYv4lpqyF0oKoSk2XtMe5SrXspOZMpr2pefLLMUxvxTWT7y+z+TGj3YXQm5WUCH85brcaqWB8c2zqzLxTE8QNoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kzbio585ZMSDylgFkZKq+LfgH8IUk0wt5wfXaCmUpjdyZFaOkK+XZFvB+Id1x7zNr9oQkKAkFa+8Dn09h2C4xWgl3yBNqP3EbzOSolqcpJ2E/o4eVUIHQ/aJGAxHAYlziht91rA5gJwx72im2TQweVtTLvEkIJiRyXZAdlWoF0gY8CRgiRFVm0JFefrYGsPGRAGfYrVR8vSRQXo3HxNRfpYktZI3seIiSVqFPbceEplOCyQRxUE4JIu+6zOuQoG4eyDrK7a5DSaz+qIT4UYZrnPtO5O7I4b+Kk+PX1zYXWYYCMnnfyOwnVpWLBc+tmDiHZ45HAlj87uDNYxkr5rYig==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 23 May 2022 15:38:56 +0000
- Ironport-data: A9a23:pZlYp64eucWVihihYYfoYgxRtArGchMFZxGqfqrLsTDasY5as4F+v mBOWjrTOviDY2GneogkPIvlpkNXsZLQm4RrQANv/yg0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS+FTYzE/TIid87dCJnSzN6ZrBeyIb+dC3XXcy7lyUqclPK6tA2VgQaGNZd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4MGtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK+fZovDmMnGSd1pDPbf6OfcWpGPlJvU295 Wzsw2/THkgjYYn3JT2ttyjEavX0tSHmXIMfEpWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwajvHeOsxoYWtxRO+438geAzuzT+QnxLmIJVCJbYdoq8so/XyU31 0ShlsnsQzdotdW9S3iQ67OVpjOaIjUOICkJYipsZRQBy8nupsc0lB2nczp4OKu8j9mwFTSrx TmP9Hc6n+9L0ZBN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLpm4U2l/MBVfNgwIQ==
- Ironport-hdrordr: A9a23:P101dqEUs6NKD3swpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYbrSoBny5rzyC0E2y+TdaF5bLfK0sjRSAgAALyQA=
- Thread-topic: [PATCH v5 4/6] xen: Switch to byteswap
On 23/05/2022 15:56, Julien Grall wrote:
> Hi,
>
> On 23/05/2022 15:50, Lin Liu wrote:
>> Update to use byteswap to swap bytes
>> be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter
>> one explictly
>
> But why?
Because deleting code obfuscation constructs *is* the point of the cleanup.
> I really don't have a suggestion on the comment because I disagree
> (and AFAICT Jan as well) with the approach.
Dropping the obfuscation has uncovered pre-existing bugs in the
hypervisor. The series stands on its own merit.
While I can't help if you like it or not, it really does bring an
improvement to code quality and legibility.
If you have no technical objections, and no suggestions for how to do it
differently while retaining the quality and legibility improvements,
then "I don't like it" doesn't block it going in.
I specifically do like this change, because it does improve the codebase.
~Andrew
|
