[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()



On 23/05/2022 08:00, Michal Orzel wrote:
Hi Julien,
Hi Michal,


On 22.05.2022 18:59, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

xsm_deasign_dtdevice() will indicate whether the caller is allowed
s/deasign/deassign/

Good spot! I will fix it on commit unless there are any objections.


to issue the operation. So the return value has to be checked.

Spotted by clang static analyzer.

Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support 
DT device")
Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Apart from that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

Thanks!

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.