[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 5/6] tools: Use new byteswap helper


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Lin Liu (刘林) <lin.liu@xxxxxxxxxx>
  • Date: Tue, 24 May 2022 02:13:15 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EyxD1VU65ez7Qp9e4oA/6H0iqQo9B+47QKdSXP4oZy0=; b=C7AfdZkuKC+fWio78GDB+I2ibc9HC+Y9HR7uCY29LVFbSXo4ZMbCsMuq3zf71dTeL1sxJQIcnx50+jtDjCNtMytzC4V8nU22EGPlR434riq/wHcK9nTYUDHMXziLSJkoztYsvn5IWoP9peHWmA2gT3+vqHKqJNuaxzs25zKuh/vCVDfnbvNUhmQhUoRofcDqe+vORVjTnXbJhw+K+POVZmJtbhX4MfAVNSCtVh0uJZq84QsF4JQwrl10bkTQVipTDeBYP1V/pLa8t1Mv3D+M8Cil2yX4FmQx2Uw2xazhruA0AdSsBrkKzkwSfRYObyMJ02jwaYs/v7/tDLie9jEgOw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B3K3f+v3TPWmEg0xYNQE9hwEkp8TRX1Cnv534BCMQeByo3EL9zVZUG3vaJkPwcIx0bqT0Qr/xVry3/+zcKc4FfisXUJNcdDcEnO5BG3lxpttX12ybc1tBTKY+MOJGYRSIrpS3hiCC5ehCp8DX9zJigaaELs4sk3LIg5QpFma+H2PShbGsv9+K5Jd5vv1LRHiwgzNSqL2j2TTEf6ekjNk4v69d2U+pu9LxK4EVWY21W+BPijIAGIDiSF/N22zqDud+uxlpZqzvh2q10wJs7arlz4gL0WlHy8lnzry8ZyA5PJtHq+BlYqZtxteFXPrzf06GQbikyoD66wxml32d7VtQQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 24 May 2022 02:13:26 +0000
  • Ironport-data: A9a23:E+mWe63wH40rcZZ3nvbD5dZwkn2cJEfYwER7XKvMYLTBsI5bpzMAx jdOWG6FaKzZNDfye9skOoTn9RgB6pTcz9I1TQFppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Cl6OqExYqfZfho9UUVh9zSH15EJ1JreqvzXiX6aR/zmXgWl61m7BEKh5zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+bBfySube03x9p7ixKNfLfY YwdaCdHZxXceRxffFwQDfrSmc/33CGmK2AF9jp5o4Iv4lTr3gMr1oHOPeLnVf/NdPV6hxex8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ1hHWDy2pVDwcZPXO5ruO+kVWWQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsSzdAbJksspAwTDlzj luRxYqxWXporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9kDSW517YRY36piG
  • Ironport-hdrordr: A9a23:mzuTlaHzzu39Ta2opLqFXZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8ATeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFr9dQnGlq/1vitR5zyJSLsZ4J0upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyJS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHOpALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDfRHXJ9upGpH 3saiIoiYdpQTORNSSn5uw6zjndBGOgQD/q1sZSo5Bkp7yUfsuYDRG+
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYbordwufrrqV0k06ypnfJmfxjlq0sTnKAgAD4X1E=
  • Thread-topic: [PATCH v4 5/6] tools: Use new byteswap helper

On 23.05.2022 11:52, Lin Liu wrote:

>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p)

>>        return cpu_to_le32(*p);

>>  }

>> 

>> +static inline u32 le32_to_cpu(u32 val)

>> +{

>> +   return le32_to_cpup((const u32 *)&val);

>> +}

> 

>Why the cast? And why not uint32_t?

> 

>Jan

 

le32_to_cpup has following prototye and definition

 

static inline u32 le32_to_cpup(const u32 *p)

{

        return cpu_to_le32(*p);

}

 

xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep consistent

typedef uint32_t u32;


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.