[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 25 May 2022 10:52:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1btQ+fYTf0FYETmvwAIv7s8JzV+qrhowIJ762Rxuw0=; b=ck7RpdPcD9yvlPqpC7bC+Y2+7WqSh0eOCzFKORSH7NG9K6RVA2jMz8nl6pmEWV6II7HPu3JRYbNPLLiJCOmUFeWiv+qiIbZO9jJA1ggugfU39Lv4taBao2wvv9vp0ERIlWyCf1jYG/cV0pybj6gEOGjT/1h3HIlUtXC0fJTU8cLXHcxiI9WiFf/NiTPKMWX4QCxbDJps32nCnOL/wL9IyPiGI05DG39T4QH0lSNRvONiviTR/smX+ZakWhwtA5nem5EPbXJgO6Hyko5ejdK3DX6tFzQdn6FKfSDD7Yzh/sCJGchXezL4EVIflkYaczP8gYouA2WbTlcysflqBNat6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRFQTRbHZ8fIwTj0W9sdYptzkebgcfMhGBGSRhVEQBcXMQEqkjjlMowQFcy0vENqrSbPNXgBGvGgTlvrhPunIMibkq+nC5MoT9U8UDhegibpPQd9VlsZ7Hwwyzaitplb+ROi/IKvR+yMi5/E7ntLhDte/6DxAa0TLLxmNXX8LFpEJHsqo7X0T4zyT6eMtHzwcxJXHKSADEFhe6i+/JfKHeEL0Pszyo5gUrEz9bJ7B6GPVQH8vGP82Vg4qpmIogaYLWbDz60UO/GEAE0yHCGokf2mC4DZAkxc49l0bDRxohJujxPbMV+mhGEf28UNo2GXS6JV+4XG8OEfxdEkF163Rg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 25 May 2022 10:53:05 +0000
- Ironport-data: A9a23:XEI12ag09trqPqPHjqmEvBb7X161ExEKZh0ujC45NGQN5FlHY01je htvXGHQM/zbN2WmL98lbtnno0sA7JLVz9YwQAprriAzFigb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnQ4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQYZFLfhmtg0aTV/Sh9yApdCxLbEJ3fq5KR/z2WeG5ft69NHKRhveKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIAehWlg7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJovzaOklwtj9ABNvLzSsaxZcpKhX2Ki XL34EvHGkkYb4KmnG/tHnWEw7WncTnAcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ CQ8+CAjsKwz/0yDVcTmUluzp3vslgEYc8pdFas98g7l90bPywOQB2xBQjsfbtUj7ZYyXWZzi A/PmM71DztytrHTUWia6rqfsTK1P24SMHMGYigHCwAC5rEPvb0Os/4Gdf47eIbdszE/MWiYL +yixMTmu4gusA==
- Ironport-hdrordr: A9a23:2YZZB6iv9QDQdFqWG5w2wQZY/XBQX4N23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqaJbp0
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYcA9OnQ9W6lKd/EmmrY4D8odolq0vawYA
- Thread-topic: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST
On 25/05/2022 09:13, Roger Pau Monne wrote:
> Rename the flag to better note that it's not actually forcing any IPIs
> to be issued if none is required, but merely avoiding the usage of TLB
> flush assistance (which itself can avoid the sending of IPIs to remote
> processors).
>
> No functional change expected.
>
> Requested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v2:
> - New in this version.
:( This needs reverting.
It is specific to IPIs, because of our current choice of algorithm for
freeing pagetables.
"no assist" excludes ipi-helper hypercalls which invoke
INVALIDATE_TLB_VECTOR. Such hypercalls do exist and specifically would
be improvement that we ought to use.
Furthermore, we do want to work around the limitation that created
FLUSH_FORCE_IPI, because we absolutely do want to be able to use
hypercalls/remote TLB flushing capabilities when available.
I accept that FORCE_IPI perhaps isn't a perfect name, but it's a whole
lot less bad than NO_ASSIST.
~Andrew
|
