[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xenstore: fix event sending in introduce_domain()



Hi Andrew,

On 25/05/2022 11:59, Andrew Cooper wrote:
On 25/05/2022 11:55, Juergen Gross wrote:
Commit fc2b57c9af46 ("xenstored: send an evtchn notification on
introduce_domain") introduced a potential NULL dereference in case of
Xenstore live update.

Fix that by adding an appropriate check.

Coverity-Id: 1504572
Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on 
introduce_domain")
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Committed.


Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> seeing as I've

b4 will end up to pick "seeing as I've":

42sh> b4 am 21392cc6-55b6-647e-08eb-c818d6229603@xxxxxxxx
Looking up https://lore.kernel.org/r/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net Grabbing thread from lore.kernel.org/all/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net/t.mbox.gz
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] tools/xenstore: fix event sending in introduce_domain()
    + Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> seeing as I've
  ---
  ✓ Signed: DKIM/suse.com
---
Total patches: 1
---
 Link: https://lore.kernel.org/r/20220525105549.30184-1-jgross@xxxxxxxx
 Base: applies clean to current tree
git am ./20220525_jgross_tools_xenstore_fix_event_sending_in_introduce_domain.mbx

I don't think this is fixable in b4 because we allow to have additional information after the tag (e.g. # arm).

So would you be able to avoid adding words after the tags that are not meant to committed? This would reduce the amount of manual work when committing.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.