[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 26 May 2022 15:28:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=FtD9idBfiPPwkLwsYLSBsVQJo6hO5aOhmSRxfo130KaJ88pwoHccLNDxxnFji2SFW54ig7apQnrdwdrEn5XxZ8FJcSyeo6OEMIo4/oKF4yDnbt/rHk56YY5mhx/Ddrpsz6xeqh9iHQ3jff7gg/ww8Qt3s/Naysez2NeN8jfsYrwN1M9yzpzFr5LAXeB0CNROfxg/VkYOe8UvlHTaoruJ0tnMrxaaKtGnuvyZlMc+75HDkc/qn39dF6LXvs+7d66dC9O5kYBizfEakUCrNj/t7bdWDchtXYP04L+Wfrkbq66VM1PqK7nqCDsf6A1e6jGQB+jnRiCQ6VzN874e7oysoA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=FnVi8NfiAx8v+s2BPSuUzjEaJS1+L39DzozmjDo0OEq8DRAD+7o+9zfrqskTAMXVpH8spoxZCTmIGpMPIZh2aeqxEz8ntVd4IvXWL8oT2gWxXuLXpJtzkAv6O+YDk9ab70ePp7AXD3p8py5fbAzlc7EUN7B52epksFO/JTzPq56LLq2uGeyTqRut3MlW2LKBs+am7SK3FgoxOXlZAzWotYQ7nRMYPtCVI1KGJRMo/NarTlwdmyGhTkd4RhARHPizdylqElepGiptu+jz+/y/0siWFyOPVFRqkPjPR7EgR7pd/Q+/SvrzNWz7TI90hSLYFnF89oYXRa8NIemhWK6Daw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MRsFpK0KPCBQ9DnN8JnDthpTy76XxHOGqngO7IAt6DNxRaTjBmQYCFSSiT+GKJCQ3WkGQ/amiQeV2N1YKVbs8DBQQTuIVfp+mefJViFUjC5EjDKu6Kns5XM7FC6y6N2OfmTrLbxIh2Q2X+NVCmKUWTvJVLV9S3knosLHD3zMMuSFp6t+8E8GWHY9vuxinwy0TZj0opX3a7ygNtAqBhDFvOseY/a3StNF/eXJ6Kq1hUcAfqwk+rYewlzvqn/Oxd9lXfq3sZxlFrdPKvMiqDVim+l2s7saS/n4PYJT8WvagOH+Aif2a6K13c9UIQpwReKIllfK6RuhUKHW1h+pjZXGSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXQ6IbxqVie+hmKkxzmENGh+HU43SgAUbYKKLLVFpqKyCvC1f9VNMxAOzM7t2KRS2lGHCm7PaRNnPLZEyVlElDSEqTvpp0qsFI/onDFTbKoFA6vqyOWMT/Q1IkQmHznsyZ6Pm9REVc4F5wbRo9F1i5pc+t3cKF8a+P9cl2ykaID3HUG5Asz936ya1WoD4ogJ2XKS7zXiCu1AnPSeRswOElIxXajWYwvjcjMdN1P/Efu+DKX9GFfdIW16vVt2w6n48X8TI+U51OXudSDRoCG7o1ivuxR0cA4yKybsM+dDwQaQV4QLCAqBdm9qq2crC0N69vVsRi9XDMi18HIj7R0u+w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 26 May 2022 15:29:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYbEKl21ixnwqV4kWdLSxbd0iWW60xUfcA
- Thread-topic: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted
> On 20 May 2022, at 13:09, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Currently, the function xen_pt_update() will flush the TLBs even when
> the mappings are inserted. This is a bit wasteful because we don't
> allow mapping replacement. Even if we were, the flush would need to
> happen earlier because mapping replacement should use Break-Before-Make
> when updating the entry.
>
> A single call to xen_pt_update() can perform a single action. IOW, it
> is not possible to, for instance, mix inserting and removing mappings.
> Therefore, we can use `flags` to determine what action is performed.
>
> This change will be particularly help to limit the impact of switching
> boot time mapping to use xen_pt_update().
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Hi Julien,
It looks ok to me. I’ve also tested it starting, console-ing, destroying few
guests
and I’ve got no problem
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
