[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 26 May 2022 17:10:41 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=T6UG6EpCRaio0+dMP0a5Z5dCPGdaQN9vYiU/K2FtYYuS9T8mQSS+f54xIWP4Lrf7d5QwQqI9O6CTWKxqlJJqHPgD0UqJh8QJJX0o5yvY/8pYUUEFyJkBQqvjXos82pomlbFW0rxhVZAIRsQhdHlTvylha/3xnXMzVI0UPJu72Nbad40QEeFtcjhYtbwmF/mS+e+0LU5lD2goHdoAAsNw96jkCMCjAb4lGatRcc6IlCupthriju+InOvLyvKGDCnPzlsVhM/Gc1lWaOmmdQz/62KIy6M4NG89biJAXozcEzGsOQxGRJqaW6iSB2sQT5/EGm3LbYOlJBhUrL3IRGgviw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=Vs4SmI45QAUqc1Cd6OkERIz6lVxoV4KmwOeAH0PgfZl+usniFfFxdk7HYgvNNKke4oRu2YLvs3tP3Bzo6W703vUI/Ghs7brCFCMjhrA1brUSm0GpSoDNbcTYoRaFLBB27hCkwQQAeNwmSwdVIZY2E/PsqRRJ9eEw+tisdMyoCeZZkELl6vhLnGQ/lsvZtx/C4tu2E093/6uOLyk522aezNmPshVYfFqZPu8b1CbxemDgyQeM0PxC8YCwvUdhUx/DkyQT2MFfEQu9qUexnzh7TTLVxW60Yxxk89ijS57OTDGFnEzlIN5NZlME2KSF3krB8v9x5v0ZfpWtiknpoIrOjA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QotCX9UJ6L+witQgMtSnwAljFP5agSW/iMsD7ncCIz7QgakIOPh6UH3EBEfcEumHFO009n01ahQPyhyYNMQz8Bt/MwPOq9wPRJ69lQvYRjq772J+H+5pggtgWf3qNa09CnMb2V1UE2jKGo4iy5fvmUe2Arb6BYlrsEMJcnqdbAm/s9m0xjX1Yywdn2Xxxzjw1w+JyWIZFTi1P66szAmwjuERuVwutVp4YTcElfYFmHIqt3hlqrOoECYr8VJzzUD5hg7X5kAF22KrH4n9Rdbw10RDIvnfLnB9By9MfRQtrPOre4lW21R2SCsuWXHfzRfjqIJKvjsqZql5XulFSker4A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GuCwCsAEpYxAitZWds6aQU73i0ULoVxS6TpD8z0mOXyx467NkyVm82n6BT7fHJXZgHYgHwxh0X0NDjow9A/HiE2T1k1wZ1PoSXbmc+F8bIPrMxuCKJH9GOuKoFtROpL8G/15mGTHnVfKWjvzd8KFr2WUu0t0C57uysJDfyghgEg0M1sp8P73P2Jk5hLtDL1tEIP8RuTRJ+/cyBnT4PDXpWcYGdmz84foCZ8FFqy/l8xAFpnxEez9r143yjB7GTYNNlNz6cp4SCSRD2csoKcZN8Mr6pVg3fwfUcbr3FYFgjfWVytJq1f4jW88zmfaUKaTj6FdbXgv7e9rSnQfaYNJxw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 26 May 2022 17:11:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYbENEz/LzQKbbT0SYYuE1BYAePK0xboeA
  • Thread-topic: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first


> On 20 May 2022, at 13:09, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Currently, memory is added to the boot allocator after the xenheap
> mappings are done. This will break if the first mapping is more than
> 512GB of RAM.
> 
> In addition to that, a follow-up patch will rework setup_xenheap_mappings()
> to use smaller mappings (e.g. 2MB, 4KB). So it will be necessary to have
> memory in the boot allocator earlier.
> 
> Only free memory (e.g. not reserved or modules) can be added to the boot
> allocator. It might be possible that some regions (including the first
> one) will have no free memory.
> 
> So we need to add all the free memory to the boot allocator first
> and then add do the mappings.
> 
> Populating the boot allocator is nearly the same between arm32 and
> arm64. The only difference is on the former we need to exclude the
> xenheap for the boot allocator. Gate the difference with CONFIG_ARM_32
> so the code be re-used on arm64.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> 

Hi Julien,

Seems ok to me!

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

I’ve also tested on arm64 patches until this one and no problem.

Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.