Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

[Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>]

On 13/5/22 20:09, Bernhard Beschow wrote:
> This function was declared in a generic and public header, implemented
> in a device-specific source file but only used in xen_platform. Given its
> 'aux' parameter, this function is more xen-specific than piix-specific.
> Also, the hardcoded magic constants seem to be generic and related to
> PCIIDEState and IDEBus rather than piix.
>
> Therefore, move this function to xen_platform, unexport it, and drop the
> "piix3" in the function name as well.
>
> Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
> ---
>   hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++-
>   hw/ide/piix.c              | 46 ------------------------------------
>   include/hw/ide.h           |  3 ---
>   3 files changed, 47 insertions(+), 50 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>