Re: [RFC PATCH 4/6] xen/riscv: Add sbi.c, sbi.h

[Xie Xun <xiexun162534@xxxxxxxxx>]

Hi Jan,

On Tue, 31 May 2022 at 15:54, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 31.05.2022 08:57, Xie Xun wrote:
> > Signed-off-by: Xie Xun <xiexun162534@xxxxxxxxx>
>
> Is this correct / complete, considering ....

Thank you for pointing out this problem.

I have read the submitting guide
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by

and it says that signed-off-by indicates I certify the patch under the
"Developer's
Certificate of Origins".
And in the "Developer's Certificate of Origins":
        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

Because Xvisor is also distributed under GPL, i think it will be
correct if it is
signed-off-by Bobby. The problem is that I did not modify this part of the code,
so I want to know how to submit this patch in a correct way?

Thank you for replying.



>
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/sbi.h
> > @@ -0,0 +1,275 @@
> > +/**
> > + * Copyright (c) 2021 Vates SAS.
> > + *
> > + * Taken from xvisor, modified by Bobby Eshleman 
> > (bobby.eshleman@xxxxxxxxx).
>
> ... this?
>
> Jan
>