[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 5/6] xen/riscv: Add early_printk
- To: Alistair Francis <alistair23@xxxxxxxxx>, Xie Xun <xiexun162534@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 1 Jun 2022 08:37:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qlp3TaauqFQczu+72cAPOsSh/Z9upua5oV5Z+S8Lczc=; b=G6Hv9Hg/N1ul/XgsAClCxSehwayrLJ8DcXG0aXen1kNVsEyyKaqInNwqpb/heTB6oJpjU4oCi3puq0eBokH1QyL3gjkcyHd/BGFt1S1FwRTzQrMnobhPSPnGUWpD3thiSudiapImuyvv97kPvWKzzXOgs0jNRkASlhA8ne2YEUnJG5ev5cQiO+KRf8V8rVvuUvarD88JE+7BDGq8zrdkdUguD/oZ+hBNjCZwTPy/eX4pGEERXRMzXdX8cLfB4Xy9Ew3V5Bi8KDuWVXF7V1tfx1MHN4uzmewBj37ZLTaN4zqu6Q0R9VblSQurDJpsHD1eTSsAoPzHyfOle6xMAR6UAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jv0zS+stuwUCXEz5Kgt8zNtvmlU3x3c4Pkb9Z6AD2Mj54PI86USzcYB29USy/vIPjy9rzu3bERNkrlD0oI6+SmGAbcTqqLap3fDiuKQw7Uupc14Fjdj1juQiaAAiFzH+TFJrvffzNKYLojzJ2n/TBU/JAvAQuyOWzYW5dV8hLzMNZ+r25HDHS5o6SXPt0M3n5eti6YU6Fhf1ldKlSnFY6mFU7B0y3LA4c4yXsFnltribG9XUQmr97R/L8Hp5W/E0QFhm7n7swFqMk0hS4gz4ESHAxMXHfnrVIxmyVi7e7/NwBSUeU6zX2EfkHKzPOthxlY8hjSUEqOQf+DSG4mR2NQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>
- Delivery-date: Wed, 01 Jun 2022 06:37:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.06.2022 05:59, Alistair Francis wrote:
> On Tue, May 31, 2022 at 5:09 PM Xie Xun <xiexun162534@xxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/xen/arch/riscv/early_printk.c
>
> This should be named differently. This file should be called
> `sbi_console_early_printk.c` to better indicate that it's using the
> sbi_console
To not go overboard with file name length, perhaps sbi-earlyprintk.c
or sbi-early-printk.c would suffice? Or, if other variants are to
appear, *-sbi.c?
> The SBI print functions are useful, but they have been marked as
> deprecated with no future replacement (see
> https://github.com/riscv-non-isa/riscv-sbi-doc/blob/659950dc57f9840cf8242c1cff138c2ee67634bb/riscv-sbi.adoc#5-legacy-extensions-eids-0x00---0x0f)
>
> For the initial port I think it's ok to use these, but this isn't a
> long term solution, we should aim to migrate to using the standard
> hardware UART.
>
> I'm sure Xen already has a driver for the ns16550 UART so it might be
> worth just using that directly and not worrying with the sbi_console.
Of course we have a driver for that, but depending on the device flavors
in use on RISC-V it may require touching.
Jan
|
